Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of the command XGROUP DELCONSUMER #2141

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Add support of the command XGROUP DELCONSUMER #2141

merged 4 commits into from
Mar 9, 2024

Conversation

Yangsx-1
Copy link
Contributor

@Yangsx-1 Yangsx-1 commented Mar 7, 2024

Close #1730

This PR add the XGROUP DELCONSUMER command.

@git-hulk git-hulk requested a review from torwig March 7, 2024 07:46
@jihuayu

This comment was marked as outdated.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
12.3% Duplication on New Code (required ≤ 5%)

See analysis details on SonarCloud

jihuayu
jihuayu approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@jihuayu jihuayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@git-hulk
Copy link
Member

git-hulk commented Mar 9, 2024

@torwig Does this PR look good to you? if yes, we can merge since @jihuayu has approved.

@PragmaTwice PragmaTwice merged commit 7d61e94 into apache:unstable Mar 9, 2024
29 of 30 checks passed
@Yangsx-1 Yangsx-1 deleted the xgroup-delconsumer branch March 11, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torwig torwig torwig approved these changes

@PragmaTwice PragmaTwice PragmaTwice approved these changes

@jihuayu jihuayu jihuayu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of the XGROUP CREATECONSUMER and DELCONSUMER
5 participants
@Yangsx-1 @jihuayu @git-hulk @torwig @PragmaTwice