Skip to content

Make JDK25 available for jbang#14861

Merged
koppor merged 1 commit intomainfrom
fix-ci
Jan 17, 2026
Merged

Make JDK25 available for jbang#14861
koppor merged 1 commit intomainfrom
fix-ci

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jan 17, 2026

User description

Fix CI

Follow-up to #14859

Steps to test

Can only be seen in main

Mandatory checks


PR Type

Enhancement


Description

  • Add JDK 25 setup to CI workflows for jbang testing

  • Configure Corretto distribution with latest version check

  • Apply JDK setup to two separate workflow jobs


Diagram Walkthrough

flowchart LR
  A["CI Workflows"] --> B["tests-code.yml"]
  B --> C["Add JDK 25 Setup"]
  C --> D["Job 1: Conditional Setup"]
  C --> E["Job 2: Unconditional Setup"]
  D --> F["Corretto Distribution"]
  E --> F
  F --> G["Check Latest Version"]
Loading

File Walkthrough

Relevant files
Configuration changes
tests-code.yml
Add JDK 25 setup to workflow jobs                                               

.github/workflows/tests-code.yml

  • Added JDK 25 setup step using actions/setup-java@v5 in first job with
    conditional execution
  • Added JDK 25 setup step in second job without condition
  • Configured Corretto distribution with check-latest: true flag
  • Both setups target Java version '25' for jbang script testing
+13/-0   

@qodo-free-for-open-source-projects
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@koppor koppor added dev: ci-cd automerge PR is tagged with that label will be merged if workflows are green and removed Review effort 1/5 labels Jan 17, 2026
@koppor koppor enabled auto-merge January 17, 2026 08:06
@qodo-free-for-open-source-projects
Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Use a valid action version

Update the actions/setup-java action from the non-existent version @v5 to the
latest stable version @v4 to prevent workflow failure.

.github/workflows/tests-code.yml [319]

-uses: actions/setup-java@v5
+uses: actions/setup-java@v4
  • Apply / Chat
Suggestion importance[1-10]: 10

__

Why: The suggestion correctly identifies that actions/setup-java@v5 is an invalid version, which would cause the entire CI workflow to fail. Correcting it to @v4 is critical for the PR's tests to run.

High
  • More

@koppor koppor added this pull request to the merge queue Jan 17, 2026
Merged via the queue into main with commit ca29d67 Jan 17, 2026
77 of 92 checks passed
@koppor koppor deleted the fix-ci branch January 17, 2026 08:42
Siedlerchr added a commit to st-rm-ng/jabref that referenced this pull request Jan 17, 2026
* upstream/main: (64 commits)
  New Crowdin updates (JabRef#14862)
  Make JDK25 available (JabRef#14861)
  Fix empty entries array when exporting group chat to JSON (JabRef#14814)
  feat: add right-click copy context menu to AI chat messages (JabRef#14722)
  FIX : generic error dialog and icon in Source Tab parsing (JabRef#14828)
  Factor out setup-* actions (JabRef#14859)
  Link .http files.
  Update dependency org.postgresql:postgresql to v42.7.9 (JabRef#14857)
  Add more commands to JabSrv (JabRef#14855)
  Fix JabRef#14821: Hide identifier action buttons when field is empty (JabRef#14831)
  Add GH_TOKEN to closed issues/PRs processing step
  New Crowdin updates (JabRef#14854)
  New Crowdin updates (JabRef#14849)
  Chore(deps): Bump jablib/src/main/resources/csl-styles from `0201999` to `f345aa8` (JabRef#14833)
  Add support for book front covers, again (JabRef#14777)
  Readd min width to button in new enty dialog (JabRef#14791)
  Replace plugin impl from jbang plugin (JabRef#14846)
  Revise AI policy wording
  Chore(deps): Bump jablib/src/main/resources/csl-locales (JabRef#14677)
  Update dependency com.konghq:unirest-modules-gson to v4.7.1 (JabRef#14845)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge PR is tagged with that label will be merged if workflows are green dev: ci-cd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants