Fix #14821: Hide identifier action buttons when field is empty

[abhishek9773]

User description

Closes #14821

Steps to test

1. welcome screen -> in start section ->(click) new empty Library
2. (JabRef Main menu bar) -> (click) Library -> Add entry .
3. Observe Empty State: Navigate to the General tab; verify icons are hidden for empty DOI/Eprint fields .
4. Trigger Icons: Type text; icons should appear immediately.
5. Verify Layout: Clear text; icons should disappear and layout should expand.
6. For one more field verify -> Step 3 switch to Optional fields -> ISBN (Observe step-4,5 behaviour )

Visual Verification

Screencast.from.11-01-26.03.01.55.PM.IST.webm

Mandatory checks

• I own the copyright of the code submitted and I license it under the MIT license
• I manually tested my changes in running JabRef (always required)
• I added JUnit tests for changes (if applicable)
• I added screenshots in the PR description (if change is visible to the user)
• I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
• I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

LLM USED: HELPED ME IN ARCHITECTURAL DECISION AND TEST CASE WRITING

---

PR Type

Enhancement

---

Description

• Bind identifier action buttons visibility to text field state

• Buttons automatically hide when field is empty, decluttering UI

• Applies to Fetch, Lookup, and Shorten buttons for DOI, Eprint, ISBN fields

• Managed property synced with visibility for proper layout expansion

---

Diagram Walkthrough

flowchart LR
  textField["Text Field"] -- "isNotEmpty()" --> visibility["Button Visibility"]
  visibility -- "bind" --> managed["Button Managed Property"]
  managed --> buttons["Fetch, Lookup, Shorten Buttons"]

Loading

File Walkthrough

Relevant files

Enhancement

IdentifierEditor.java Bind identifier buttons visibility to text field state      jabgui/src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java Added reactive property bindings for three identifier action buttons Buttons' visibility property bound to viewModel.textProperty().isNotEmpty() Buttons' managed property bound to their visibility property Ensures buttons hide when field is empty and expand layout accordingly +6/-0

---

[qodo-free-for-open-source-projects]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Conditionally show button for specific field Suggestion Impact: The commit directly implements the suggestion by removing shortenDOIButton from the stream of buttons that are shown for all identifier types, and adding conditional logic to only show it when the field is DOI. The implementation matches the suggested approach exactly, including binding the managed property and setting visibility based on whether the field is DOI. code diff: + java.util.stream.Stream.of(fetchInformationByIdentifierButton, lookupIdentifierButton) + .forEach(button -> { + button.visibleProperty().bind(viewModel.textProperty().isNotEmpty()); + button.managedProperty().bind(button.visibleProperty()); + }); + + shortenDOIButton.managedProperty().bind(shortenDOIButton.visibleProperty()); + if (StandardField.DOI.equals(field)) { + shortenDOIButton.visibleProperty().bind(viewModel.textProperty().isNotEmpty()); + } else { + shortenDOIButton.setVisible(false); + } Separate the visibility logic for the shortenDOIButton to ensure it only appears for the DOI field, instead of for all identifier types. jabgui/src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java [95-99] -java.util.stream.Stream.of(fetchInformationByIdentifierButton, lookupIdentifierButton, shortenDOIButton) +java.util.stream.Stream.of(fetchInformationByIdentifierButton, lookupIdentifierButton) .forEach(button -> { button.visibleProperty().bind(viewModel.textProperty().isNotEmpty()); button.managedProperty().bind(button.visibleProperty()); }); +shortenDOIButton.managedProperty().bind(shortenDOIButton.visibleProperty()); +if (DOI.equals(field)) { + shortenDOIButton.visibleProperty().bind(viewModel.textProperty().isNotEmpty()); +} else { + shortenDOIButton.setVisible(false); +} + [Suggestion processed] Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a bug where the shortenDOIButton is incorrectly shown for all identifier types, not just for DOI. The proposed fix correctly restricts the button's visibility to only the DOI field, fixing a functional issue introduced by the PR.	Medium
Update

[subhramit]

@abhishek9773 thanks for the contribution.
Next time please also make necessary disclosures as per our AI usage policy - whatever you have used AI for.

[koppor]

#14821

[abhishek9773]

Hi @koppor, @subhramit,
​Thanks for the guidance on this. I’ve gone ahead and updated the CHANGELOG.md with the correct issue number (#14821) and fixed the Stream imports and indentation in IdentifierEditor.java to match the project standards.

​I also wanted to be fully transparent about my use of AI on this PR, as per the project policy. As a new contributor, I’ve been using AI as a tool to ensure my code and test cases actually reach the industry standards expected here. For example, in the IdentifierEditorTest, it helped me implement the proper interact() and clickOn() patterns for JavaFX rather than using less robust manual erasures. It's been a great way for me to learn the codebase faster.

​I sincerely apologize for the 'chaos' with the force-pushes. I was trying to keep the history clean as I learned, but I see now that it triggered the build failures and made your review harder.
​I’m not in a rush to merge- I just want to make sure I’m doing things the right way. Please let me know how I should handle the failing checks from the force-push, and I’ll get on it. Thanks again!

[subhramit]

Hi @koppor, @subhramit,​Thanks for the guidance on this. I’ve gone ahead and updated the CHANGELOG.md with the correct issue number (#14821) and fixed the Stream imports and indentation in IdentifierEditor.java to match the project standards.

​I also wanted to be fully transparent about my use of AI on this PR, as per the project policy. As a new contributor, I’ve been using AI as a tool to ensure my code and test cases actually reach the industry standards expected here. For example, in the IdentifierEditorTest, it helped me implement the proper interact() and clickOn() patterns for JavaFX rather than using less robust manual erasures. It's been a great way for me to learn the codebase faster.

​I sincerely apologize for the 'chaos' with the force-pushes. I was trying to keep the history clean as I learned, but I see now that it triggered the build failures and made your review harder.​I’m not in a rush to merge- I just want to make sure I’m doing things the right way. Please let me know how I should handle the failing checks from the force-push, and I’ll get on it. Thanks again!

Usage of AI to refine code is alright, and thanks for being transparent. However, please try to communicate in your own terms rather than copy pasting LLM responses. Please look at these guidelines. Since you seem to have understood your changes, you are also expected to write the PR description yourself instead of generating it using an LLM.
As an avid open source community, we prefer to interact organically with people.

[abhishek9773]

@subhramit Thank you for pointing me out. from now onwards I will make sure that I am following all the points you have mentioned

obsolete

[subhramit]

@abhishek9773 not sure why you clicked on "resolve conversation" without acting on review changes

[abhishek9773]

@abhishek9773 not sure why you clicked on "resolve conversation" without acting on review changes

it was mistake . i made changes to "changelog.md" file but forgot to add those changes during ">git add" and mistakenly assumed i had done so.

[subhramit]

@abhishek9773 not sure why you clicked on "resolve conversation" without acting on review changes

it was mistake . i made changes to "changelog.md" file but forgot to add those changes during ">git add" and mistakenly assumed i had done so.

look for this "outdated" label before resolving conversations:

[koppor]

The concept of JabRef is to DISABLE buttons, not to hide.

This PR trashed the functionality to look up a DOI. Look up means: If there is no DOI, search the net for it.

[koppor]

Did someone understand what "lookup" means?

[abhishek9773]

I misunderstood the behavior and took the word “hide” literally.
I also understand that “lookup” should work even when there is no DOI, by searching online.

I can change the code to disable instead of hide. Is this what you mean?

[koppor]

Thank you for the offer. Your past PR needed more than 10 comments of two different maintainers. Still the code did not work. Your code is just hacky - and did not build on existing (!) JavaFX code. Thus, we should save the time of both you and the team. -- In future, please first read around at the code base. The IdentifierEditor is a very nice example to learn about JavaFX bindings and general UI principles in JavaFX. You missed this opportunity.

I already fixed it at #14931.

[koppor]

The code totally overlooked org.jabref.gui.fieldeditors.identifier.BaseIdentifierEditorViewModel#canShortenIdentifier