Skip to content

Comments

boost: avoid zstd opportunistic linkage#39117

Closed
scpeters wants to merge 1 commit intoHomebrew:masterfrom
scpeters:boost_no_zstd
Closed

boost: avoid zstd opportunistic linkage#39117
scpeters wants to merge 1 commit intoHomebrew:masterfrom
scpeters:boost_no_zstd

Conversation

@scpeters
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This is an alternative to #39112 that fixes #39111 that tries to avoid opportunistic linkage rather than adding a new dependency to boost. I'm not sure if more things downstream will need revision bumps as well.

cc @colindean

@scpeters scpeters mentioned this pull request Apr 19, 2019
5 tasks
--layout=tagged-1.66
--user-config=user-config.jam
-sNO_LZMA=1
-sNO_ZSTD=1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scpeters
Copy link
Contributor Author

cucumber-cpp also failed on 10.13 in the boost 1.69 pr: #35030 (comment)

@fxcoudert fxcoudert closed this in 78f6cc4 Apr 20, 2019
@scpeters scpeters deleted the boost_no_zstd branch April 20, 2019 00:07
@scpeters scpeters mentioned this pull request Apr 23, 2019
5 tasks
@lock lock bot added the outdated PR was locked due to age label May 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost 1.69 introduced dependency on zstd?

3 participants