boost: avoid zstd opportunistic linkage#39117
Closed
scpeters wants to merge 1 commit intoHomebrew:masterfrom
Closed
boost: avoid zstd opportunistic linkage#39117scpeters wants to merge 1 commit intoHomebrew:masterfrom
scpeters wants to merge 1 commit intoHomebrew:masterfrom
Conversation
5 tasks
scpeters
commented
Apr 19, 2019
| --layout=tagged-1.66 | ||
| --user-config=user-config.jam | ||
| -sNO_LZMA=1 | ||
| -sNO_ZSTD=1 |
Contributor
Author
There was a problem hiding this comment.
build parameter found from the following Jamfile:
fxcoudert
approved these changes
Apr 19, 2019
colindean
approved these changes
Apr 19, 2019
Contributor
Author
|
cucumber-cpp also failed on 10.13 in the boost 1.69 pr: #35030 (comment) |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This is an alternative to #39112 that fixes #39111 that tries to avoid opportunistic linkage rather than adding a new dependency to boost. I'm not sure if more things downstream will need revision bumps as well.
cc @colindean