Skip to content

Comments

Adds zstd dependency for boost#39112

Closed
colindean wants to merge 1 commit intoHomebrew:masterfrom
colindean:patch-2
Closed

Adds zstd dependency for boost#39112
colindean wants to merge 1 commit intoHomebrew:masterfrom
colindean:patch-2

Conversation

@colindean
Copy link
Contributor

Homebrew's boost 1.69 includes support for iostreams-mt, which establishes a dependency on zstd.

Fixes #39111

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

#38890 takes boost to 1.70 but this problem is preventing use of at least one formula presently.

Homebrew's boost 1.69 includes support for iostreams-mt, which establishes a dependency on zstd.

Fixes #39111
@scpeters
Copy link
Contributor

Does this need a revision bump? I think the INSTALL_RECEIPT.json will be out of date if we don't rebuild the bottle, but I'm not sure if that's a big problem or not.

@scpeters
Copy link
Contributor

This looks like a consequence of the boost bottle update from #38439.

Adding a dependency to boost has a big impact, so if there is an option to prevent the opportunistic linking, I think it may be worthwhile. If there is demand for this feature, that's one thing, but I'd rather it be an explicit choice than following the whims of opportunistic linking.

@scpeters
Copy link
Contributor

FYI, I submitted my proposed alternative in #39117

@fxcoudert
Copy link
Member

Let's avoid the opportunistic linkage rather than add a new dependency.

@fxcoudert fxcoudert closed this Apr 19, 2019
@colindean colindean deleted the patch-2 branch April 19, 2019 23:32
@lock lock bot added the outdated PR was locked due to age label May 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated PR was locked due to age

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost 1.69 introduced dependency on zstd?

3 participants