Closed
Conversation
Contributor
Author
|
I think bottle updates aren't needed, since this just updates the test. |
Contributor
Agreed. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?The cucumber-cpp test has been failing in high sierra. The standard trick of
ENV.delete("SDKROOT")wasn't quite enough, as it gave a bunch of errors like the following:So I looked into it further and saw that there are a bunch of other environment variables that reference the 10.14 SDK in Xcode:
Since the 2nd failure seems to be related to C header files, I added
ENV.delete("CPATH"), and that seems to be enough.Perhaps this method will help with
graph-tooland other 10.13 failures.