boost 1.69.0

[lembacon]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[lembacon]

Well, starting Boost 1.69, the tagged layout will include <arch-and-model>. 🙃

https://github.com/boostorg/boost/blob/boost-1.69.0/boostcpp.jam#L156-L157

The library name will look like libboost_regex-mt-x64.dylib, including a -x64 suffix in this case.

[lembacon]

Well, starting Boost 1.69, the tagged layout will include <arch-and-model>. 🙃

https://github.com/boostorg/boost/blob/boost-1.69.0/boostcpp.jam#L156-L157

The library name will look like libboost_regex-mt-x64.dylib, including a -x64 suffix in this case.

I think we should keep the layout as-is for now, so I've changed --layout=tagged to --layout=tagged-1.66.

[fxcoudert]

Rev-bumping needed for azure-storage-cpp bitcoin btfs cpprestsdk cucumber-cpp folly gnuradio gr-osmosdr graph-tool i2pd ledger lgogdownloader libbitcoin libbitcoin-blockchain libbitcoin-client libbitcoin-database libbitcoin-explorer libbitcoin-network libbitcoin-node libbitcoin-protocol libbitcoin-server libswiften libtorrent-rasterbar metaproxy mkvtoolnix monero ncmpcpp openimageio osquery osrm-backend pcl pdftoedn pgrouting source-highlight uhd upscaledb wesnoth widelands

[scpeters]

osquery is missing some boost headers, so it's failing before the no-weak-import issue. I submitted a patch upstream in osquery/osquery#5325, but I don't think it will apply to 3.3.0, and the build is failing anyway.

[scpeters]

The boost signals library is removed in 1.69:

• https://www.boost.org/users/history/version_1_69_0.html

I maintain one package that uses that; I need to see if we can easily switch to signals2 or if we'll need boost@1.68 in our tap.

[scpeters]

Turns out we aren't even using boost signals in the code; it was just searching for the component. I think it will be an easy fix for us; no boost@1.68 needed.

[scpeters]

I tried resolving conflicts through the gui, which created a merge commit and broke CI, so I rebased instead.

[scpeters]

A patch for osquery has been accepted: osquery/osquery@41b785b

A patch for uhd is in the works: EttusResearch/uhd#241 (comment)

[scpeters]

The libbitcoin repository was renamed at some point to libbitcoin-system, so the tarball sha256 has changed. Perhaps it should just point to the new repo name with the new sha256.

23:04:59 ==> Downloading from https://codeload.github.com/libbitcoin/libbitcoin-system/tar.gz/v3.5.0
23:04:59 Warning: Formula reports different SHA256: 214d9cd6581330b0e1f6fd8f0c634c46b75ae5515806ecac189f21c0291ae2d9
23:04:59 Downloaded to: /Users/brew/Library/Caches/Homebrew/downloads/d41fab214748b9d248e4047f456139bb9ff328c03f19df07d856ebd51ce75587--libbitcoin-system-3.5.0.tar.gz
23:04:59 SHA256: 44ecd8b0de0dff2296f03e9c7f42a0afb9ac4f916aeaf6de2bffd0ccc05790b5

[scpeters]

I've rebased and pushed two fixes:

• uhd has an upstream patch for boost 1.69 support
• changed url and sha256 for lib bitcoin

[scpeters]

that last build took 12 hours; here's a discussion of some (not all) of the failures

• libbitcoin-protocol fails to find zeromq during its build, which should be fixed by libunwind.pc: add os/mac/pkg-config files brew#5539
• metaproxy had a compilation failure; I've posted a patch to their mailing list as I couldn't find a repository in which to submit pull request
• osquery has an upstream patch that can fix its compilation error
• pgrouting needs a revision bump (EDIT: weird because it is already revision-bumped)

[scpeters]

Ok, oddly, the pgrouting test failure that inspired its revision bump is actually caused by sfcgal. So we should revision bump sfcgal and revert the bump to pgrouting:

• https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/36348/version=mojave/testReport/junit/brew-test-bot/mojave/test_pgrouting/

2019-01-15 09:23:53.402 GMT [3726] ERROR:  could not load library "/usr/local/lib/postgresql/postgis-2.5.so": dlopen(/usr/local/lib/postgresql/postgis-2.5.so, 10): Symbol not found: __ZN5boost6system6detail20generic_category_ncxEv
	  Referenced from: /usr/local/opt/sfcgal/lib/libSFCGAL.1.dylib
	  Expected in: /usr/local/opt/boost/lib/libboost_system-mt.dylib
	 in /usr/local/opt/sfcgal/lib/libSFCGAL.1.dylib

[scpeters]

I've added a few commits to my fork while we wait for
Homebrew/brew#5539

• https://github.com/scpeters/homebrew-core/commits/boost-1.69.0

[scpeters]

trying again with more patches...

[scpeters]

the build took 11 hours this time; it looks like two of my patches (690046f for graph-tool on 10.13 and 8c74c5a for osquery) didn't work. The other failures are:

• folly (pre-existing build failure related to zstd)
• libswiften (beware the 280 MB console log that eventually just says scons: building terminated because of errors.)

[scpeters]

the osquery patch should apply after osquery 3.3.2 #35941

[scpeters]

I'm testing the folly build locally and then I will push if it's ok

[fxcoudert]

After that is merged, I would expect graph-tool on 10.13 to be the only failure

Then we should proceed.

[scpeters]

I just pushed 🤞

[scpeters]

latest build:

• expected 10.13 graph-tool failure
• https://osquery.io website is down
• 10.13 failure of brew test cucumber-cpp

seems close enough to me

[fxcoudert]

Given that a cpprestsdk was introduced by another merge (sorry), I have merged everything except that. I'll handle it separately in #38115

[fxcoudert]

Congrats @scpeters @lembacon on great work!

[henryiii]

How hard will Boost 1.70 be to add? Really looking forward to Boost:::Histogram!