Skip to content

Comments

go 1.26.0, go@1.25 1.25.7 (new formula)#258912

Merged
BrewTestBot merged 6 commits intomainfrom
go1.26
Feb 12, 2026
Merged

go 1.26.0, go@1.25 1.25.7 (new formula)#258912
BrewTestBot merged 6 commits intomainfrom
go1.26

Conversation

@stefanb
Copy link
Member

@stefanb stefanb commented Dec 16, 2025 •
edited
Loading

Announcements:

Release notes:

Go 1.26 milestone: GitHub milestone details (release blockers, commits, PRs)

Go release dashboard: https://dev.golang.org/release

Downloads: https://go.dev/dl/

Related/similar previous major releases:

Builds:

Problematic dependants formulae:

Needs to be rebuilt via revision bump in this PR:

  • golangci-lint test failure: the Go language version (go1.25) used to build golangci-lint is lower than the targeted Go version (1.26)

Needs upstream fix for Go 1.26

Broken vitessio/vitess and a dependency:

Broken cockroachdb/swiss dependancies

Broken bytedance/sonic dependancies

Broken gvisor.dev/gvisor/pkg/sync / google/gvisor dependencies:

  • Change in Go 1.26: runtime: CPU limit-aware GOMAXPROCS default golang/go#73193 & https://go.dev/cl/670497
  • Upstream fix in gvisor: Adjust WaitReasonSemacquire et al. for go1.26 google/gvisor#12204
  • Upstream fix in gvisor: sync: fix go1.26 build constraints google/gvisor#12469 available in https://github.com/google/gvisor/releases/tag/release-20260112.0 and later
  • gotun (0.8.0) build failure: # gvisor.dev/gvisor/pkg/sync /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20251220000015-517913d17844/pkg/sync/runtime_constants_go126.go:22:2: WaitReasonSelect redeclared in this block /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20251220000015-517913d17844/pkg/sync/runtime_constants_go125.go:22:2: other declaration of WaitReasonSelect /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20251220000015-517913d17844/pkg/sync/runtime_constants_go126.go:23:2: WaitReasonChanReceive redeclared in this block /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20251220000015-517913d17844/pkg/sync/runtime_constants_go125.go:23:2: other declaration of WaitReasonChanReceive /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20251220000015-517913d17844/pkg/sync/runtime_constants_go126.go:24:2: WaitReasonSemacquire redeclared in this block /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20251220000015-517913d17844/pkg/sync/runtime_constants_go125.go:24:2: other declaration of WaitReasonSemacquire
    after feat: 新增tun模式支持 Sesame2/gotun#21 and gotun 0.8.0 #261055
    Build fails with Go 1.26 due to gVisor sync runtime constants redeclaration Sesame2/gotun#22
    gotun: pin go@1.25 #267430
  • xray 26.1.13 build failure: # gvisor.dev/gvisor/pkg/sync /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20260109181451-4be7c433dae2/pkg/sync/runtime_constants_go126.go:22:2: WaitReasonSelect redeclared in this block /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20260109181451-4be7c433dae2/pkg/sync/runtime_constants_go125.go:22:2: other declaration of WaitReasonSelect /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20260109181451-4be7c433dae2/pkg/sync/runtime_constants_go126.go:23:2: WaitReasonChanReceive redeclared in this block /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20260109181451-4be7c433dae2/pkg/sync/runtime_constants_go125.go:23:2: other declaration of WaitReasonChanReceive /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20260109181451-4be7c433dae2/pkg/sync/runtime_constants_go126.go:24:2: WaitReasonSemacquire redeclared in this block /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/gvisor.dev/gvisor@v0.0.0-20260109181451-4be7c433dae2/pkg/sync/runtime_constants_go125.go:24:2: other declaration of WaitReasonSemacquire
    after Upgrade gVisor to latest version v0.0.0-20260109181451-4be7c433dae2 XTLS/Xray-core#5527
    XTLS/Xray-core@9c46a2d
    xray 26.1.31 #265331

Uncategorized

Hash mismatches

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@stefanb stefanb added in progress Stale bot should stay away prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. long dependent tests Set a long timeout for dependent testing labels Dec 16, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. alias labels Dec 16, 2025
@stefanb stefanb changed the title go 1.26rc1 go 1.26rc1, go@1.25 1.25.5 (new formula) Dec 16, 2025
@stefanb stefanb added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Dec 17, 2025
This was referenced Dec 19, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@chenrui333
Copy link
Member

chenrui333 commented Dec 26, 2025 •
edited
Loading

Broken cockroachdb/swiss dependancies

refreshing the downstream dependencies

This was referenced Dec 26, 2025
Merged
Merged
Merged
Closed
Closed
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 12, 2026
@Jack-Kingdom
Copy link

Jack-Kingdom commented Feb 12, 2026

waiting for merge, anyone could re-trigger ci script?

@stevenh
Copy link

stevenh commented Feb 12, 2026

waiting for merge, anyone could re-trigger ci script?

CI failing with:

==> FAILED
Full style homebrew/core output
  Taps/homebrew/homebrew-core/Formula/g/go@1.25.rb:20:3: C: [Correctable] FormulaAudit/ComponentsOrder: livecheck (line 20) should be put before bottle (line 10)
    livecheck do ...
    ^^^^^^^^^^^^
  
  8208 files inspected, 1 offense detected, 1 offense autocorrectable

Is this something that needs to be fixed before it can be merged?

@SMillerDev
Copy link
Member

SMillerDev commented Feb 12, 2026

Is this something that needs to be fixed before it can be merged?

Yes, we don't merge with failing CI. Homebrew/brew#21561 likely fixed it, but now we need to figure out how to fix the current state of this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@stefanb stefanb removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 12, 2026
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit 91494be Feb 12, 2026
25 of 26 checks passed
@BrewTestBot BrewTestBot deleted the go1.26 branch February 12, 2026 10:06
This was referenced Feb 12, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@chenrui333 chenrui333 mentioned this pull request Feb 18, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

alias CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing new formula PR adds a new formula to Homebrew/homebrew-core no long build conflict Do not allow merging other pull requests when files conflict with this one ready to merge PR can be merged once CI is green

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stefanb @chenrui333 @andig @Jack-Kingdom @stevenh @SMillerDev @BrewTestBot