Skip to content

Comments

chore(deps): bump github.com/bytedance/sonic to 1.15.0 for Go 1.26 support#6841

Merged
dwisiswant0 merged 2 commits intoprojectdiscovery:devfrom
stefanb:go1.26
Feb 11, 2026
Merged

chore(deps): bump github.com/bytedance/sonic to 1.15.0 for Go 1.26 support#6841
dwisiswant0 merged 2 commits intoprojectdiscovery:devfrom
stefanb:go1.26

Conversation

@stefanb
Copy link
Contributor

@stefanb stefanb commented Feb 6, 2026

Proposed changes

Update https://github.com/bytedance/sonic to https://github.com/bytedance/sonic/releases/tag/v1.15.0 For

Found in

Upgraded by performing:

$ go1.26rc3 build ./...
# github.com/bytedance/sonic/internal/rt
../../../go/pkg/mod/github.com/bytedance/sonic@v1.14.0/internal/rt/stubs.go:33:22: undefined: GoMapIterator
../../../go/pkg/mod/github.com/bytedance/sonic@v1.14.0/internal/rt/stubs.go:36:54: undefined: GoMapIterator
$ go get github.com/bytedance/sonic@latest && go mod tidy
go: added github.com/bytedance/gopkg v0.1.3
go: upgraded github.com/bytedance/sonic v1.14.0 => v1.15.0
go: upgraded github.com/bytedance/sonic/loader v0.3.0 => v0.5.0
go: upgraded github.com/cloudwego/base64x v0.1.5 => v0.1.6
$ go1.26rc3 build ./...
$

Similar to

Proof

Built with go 1.26rc3 succesfully.
Multiple formulae in Homebrew/homebrew-core#258912 are already using https://github.com/bytedance/sonic/releases/tag/v1.15.0 and passing tests.

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Summary by CodeRabbit

  • Chores

    • Updated project dependencies to newer releases for improved stability.
  • Documentation

    • Updated package platform note to reflect supported Go versions (range extended).

…pport

Update https://github.com/bytedance/sonic to https://github.com/bytedance/sonic/releases/tag/v1.15.0
For
* bytedance/sonic#898

Found in
* Homebrew/homebrew-core#258912

Upgraded by performing:

```
$ go1.26rc3 build -v ./...
github.com/bytedance/sonic/internal/rt
# github.com/bytedance/sonic/internal/rt
../../../go/pkg/mod/github.com/bytedance/sonic@v1.14.0/internal/rt/stubs.go:33:22: undefined: GoMapIterator
../../../go/pkg/mod/github.com/bytedance/sonic@v1.14.0/internal/rt/stubs.go:36:54: undefined: GoMapIterator
$ go get github.com/bytedance/sonic@latest && go mod tidy
go: added github.com/bytedance/gopkg v0.1.3
go: upgraded github.com/bytedance/sonic v1.14.0 => v1.15.0
go: upgraded github.com/bytedance/sonic/loader v0.3.0 => v0.5.0
go: upgraded github.com/cloudwego/base64x v0.1.5 => v0.1.6
$ go1.26rc3 build -v ./...
$
```
@auto-assign auto-assign bot requested a review from dogancanbakir February 6, 2026 16:51
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Walkthrough

The pull request updates Go module dependencies in go.mod (sonic v1.14.0→v1.15.0, sonic/loader v0.3.0→v0.5.0, adds github.com/bytedance/gopkg v0.1.3, bumps github.com/cloudwego/base64x to v0.1.6) and adjusts package documentation in pkg/utils/json/doc.go to extend supported Go versions from "<= 1.25" to "<= 1.26".

Changes

Cohort / File(s) Summary
Dependency Updates
go.mod
Bumped github.com/bytedance/sonic v1.14.0→v1.15.0, replaced sonic/loader v0.3.0 with v0.5.0 (indirect), added github.com/bytedance/gopkg v0.1.3 (indirect), and bumped github.com/cloudwego/base64x to v0.1.6 (indirect).
Docs
pkg/utils/json/doc.go
Updated package doc comment to extend supported Go versions from "Go >= 1.20 and <= 1.25" to "Go >= 1.20 and <= 1.26".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped through go.mod with a twitch of my nose,
Bumped Sonic, added Loader, and watched the wind blow,
Base64x rose, a new gopkg in sight,
Docstrings grew taller, embracing one more night,
A tiny hop forward — dependencies glow.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: bumping the github.com/bytedance/sonic dependency to v1.15.0 and is motivated by Go 1.26 support, which aligns with both the changeset and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

We've launched Issue Planner and it is currently in beta. Please try it out and share your feedback on Discord!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dogancanbakir
Copy link
Member

tests fail

bytedance/sonic, to include 1.26

Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0 dwisiswant0 merged commit 2e1a81e into projectdiscovery:dev Feb 11, 2026
16 of 19 checks passed
@stefanb stefanb deleted the go1.26 branch February 11, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants