go/common/version: Trim pre-release suffixes#6447
Merged
peternose merged 1 commit intooasisprotocol:masterfrom Jan 26, 2026
Merged
go/common/version: Trim pre-release suffixes#6447peternose merged 1 commit intooasisprotocol:masterfrom
peternose merged 1 commit intooasisprotocol:masterfrom
Conversation
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
72 tasks
kostko
reviewed
Jan 26, 2026
Member
kostko
left a comment
kostko
left a comment
There was a problem hiding this comment.
Looks good to me, please also add a changelog fragment.
peternose
approved these changes
Jan 26, 2026
stefanb
force-pushed
the
trim-version-prerelease-suffixes
branch
from
f0f14cf to
168786a
Compare
Collaborator
|
Rebase. |
Updated version.FromString to trim 'rc', 'alpha', and 'beta' suffixes without hyphens when parsing version strings. Added test cases to ensure correct parsing of versions with pre-release suffixes.
stefanb
force-pushed
the
trim-version-prerelease-suffixes
branch
from
168786a to
72e4397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version.FromString to trim 'rc', 'alpha', and 'beta' suffixes without hyphens when parsing version strings. Added test cases to ensure correct parsing of versions with pre-release suffixes.
Ref:
panic: version: failed to parse SemVer '1.26rc1': strconv.ParseUint: parsing "26rc1": invalid syntaxafter this is merged and released it would need an update in https://github.com/oasisprotocol/cli
Thanks/Hvala!