Skip to content

Comments

Backport to v23: Support Go 1.26 and later with Swiss maps always enabled (#19088)#19367

Merged
mattlord merged 1 commit intovitessio:release-23.0from
bcremer:backport-19088-to-vitess-23
Feb 12, 2026
Merged

Backport to v23: Support Go 1.26 and later with Swiss maps always enabled (#19088)#19367
mattlord merged 1 commit intovitessio:release-23.0from
bcremer:backport-19088-to-vitess-23

Conversation

@bcremer
Copy link

@bcremer bcremer commented Feb 12, 2026

Description

Backport changes from https://github.com/vitessio/vitess/pull/19088/changes so consumers of vitess.io/vitess/go/vt/vitessdriver can update their applications to Go 1.26.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

No AI was used, it's just a simple cherry-pick of an existing commit

git cherry-pick 28105fd7ba9defbda6f5827734f1cfa1b5c2b1c4

)

Signed-off-by: Štefan Baebler <319826+stefanb@users.noreply.github.com>
@github-actions github-actions bot added this to the v23.0.3 milestone Feb 12, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 12, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 12, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@mattlord mattlord self-assigned this Feb 12, 2026
@mattlord mattlord added Component: Build/CI Type: CI/Build and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 12, 2026
@mattlord mattlord self-requested a review February 12, 2026 06:31
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bcremer !

LGTM

❯ gh pr co 19367
remote: Enumerating objects: 3, done.
remote: Counting objects: 100% (3/3), done.
remote: Total 3 (delta 2), reused 3 (delta 2), pack-reused 0 (from 0)
Unpacking objects: 100% (3/3), 409 bytes | 102.00 KiB/s, done.
From github.com:vitessio/vitess
 * [new ref]               refs/pull/19367/head -> backport-19088-to-vitess-23
Switched to branch 'backport-19088-to-vitess-23'

❯ go version
go version go1.26.0 darwin/arm64

❯ make build
Thu Feb 12 06:33:23 UTC 2026: Building source tree

❯ vtgate --version
vtgate version Version: 23.0.3-SNAPSHOT (Git revision 2257942442cefaf7bbb880d93a9b382a1e9fbd82 branch 'backport-19088-to-vitess-23') built on Thu Feb 12 06:33:23 UTC 2026 by matt@pslord.local using go1.26.0 darwin/arm64

@mattlord mattlord enabled auto-merge (squash) February 12, 2026 06:42
@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.71%. Comparing base (7c76856) to head (2257942).
⚠️ Report is 11 commits behind head on release-23.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.0   #19367      +/-   ##
================================================
- Coverage         69.73%   69.71%   -0.02%     
================================================
  Files              1606     1606              
  Lines            214823   214851      +28     
================================================
- Hits             149798   149778      -20     
- Misses            65025    65073      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber
Copy link
Member

Should we backport this to v22 as well?

@mattlord mattlord merged commit 17fcf35 into vitessio:release-23.0 Feb 12, 2026
130 of 135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants