Skip to content

envoy 1.23.1#110883

Closed
dio wants to merge 1 commit intoHomebrew:masterfrom
dio:envoy-v1.23.1-no-patches
Closed

envoy 1.23.1#110883
dio wants to merge 1 commit intoHomebrew:masterfrom
dio:envoy-v1.23.1-no-patches

Conversation

@dio
Copy link
Copy Markdown
Contributor

@dio dio commented Sep 16, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

envoy v1.23.1 does not require patches as v1.22.2 anymore. Those patches are merged.

This also introduces a patch for catalina.

Comment thread Formula/envoy.rb Outdated
Comment on lines 14 to 19
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread Formula/envoy.rb Outdated
Comment on lines 21 to 26
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 16, 2022
@danielnachun danielnachun added long build Set a long timeout for formula testing CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 16, 2022
@dio
Copy link
Copy Markdown
Contributor Author

dio commented Sep 16, 2022

@danielnachun sorry, do we need to add the CI-long-timeout label as well? Thanks!

@dio
Copy link
Copy Markdown
Contributor Author

dio commented Sep 16, 2022

Ah, sorry. Seems like we need to wait for the other running jobs (with CI-long-timeout label).

@carlocab carlocab force-pushed the envoy-v1.23.1-no-patches branch from 7f7b0cc to 85201f0 Compare September 19, 2022 17:41
@carlocab carlocab added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Sep 19, 2022
Comment thread Formula/envoy.rb Outdated
Comment on lines 38 to 40
Copy link
Copy Markdown
Member

@cho-m cho-m Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to backport envoyproxy/envoy#22334 to avoid dropping Catalina support (though not too important as Ventura will be out soon so Homebrew's main supported macOS versions will be Big Sur and newer)

Copy link
Copy Markdown
Contributor Author

@dio dio Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Submitted the backport patch here: envoyproxy/envoy#23177 cc. @cpakulski

@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Sep 19, 2022
@cho-m cho-m added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Sep 20, 2022
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Sep 20, 2022
@carlocab
Copy link
Copy Markdown
Member

Could you rebase to get rid of the merge commit and squash your commits together please?

For future reference:

Please use the preferred commit-message style for homebrew/core. We put the name of the formula first in commit-message headings.

For new formulae:

At Homebrew, we like to put the name of the formula up front like so: foobar 7.3 (new formula).

For existing formulae:

The preferred commit message format for simple version updates is foobar 7.3 and for fixes is foobar: fix flibble matrix..

Refer to the commit style guide for more details. Also, when making further changes to your pull request, use the following guidelines to make sure that @BrewTestBot can merge your commits:

  • One formula per commit; one commit per formula.
  • Keep merge commits out of the pull request.

@dio dio force-pushed the envoy-v1.23.1-no-patches branch from 8da51bc to 086c6e7 Compare September 20, 2022 06:41
@cho-m cho-m added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-linux-self-hosted Build on Linux self-hosted runner and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Sep 20, 2022
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Sep 21, 2022
Copy link
Copy Markdown
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrewTestBot
Copy link
Copy Markdown
Contributor

:shipit: @carlocab has triggered a merge.

@dio
Copy link
Copy Markdown
Contributor Author

dio commented Sep 22, 2022

Thanks for your guidance, @carlocab @cho-m!

@dio dio mentioned this pull request Oct 31, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge-skip `brew pr-automerge` will skip this pull request CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants