envoy 1.23.1#110883
Conversation
|
@danielnachun sorry, do we need to add the |
|
Ah, sorry. Seems like we need to wait for the other running jobs (with |
7f7b0cc to
85201f0
Compare
There was a problem hiding this comment.
We may want to backport envoyproxy/envoy#22334 to avoid dropping Catalina support (though not too important as Ventura will be out soon so Homebrew's main supported macOS versions will be Big Sur and newer)
There was a problem hiding this comment.
Sure. Submitted the backport patch here: envoyproxy/envoy#23177 cc. @cpakulski
|
Could you rebase to get rid of the merge commit and squash your commits together please? For future reference: Please use the preferred commit-message style for homebrew/core. We put the name of the formula first in commit-message headings. For new formulae:
For existing formulae:
Refer to the commit style guide for more details. Also, when making further changes to your pull request, use the following guidelines to make sure that @BrewTestBot can merge your commits:
|
8da51bc to
086c6e7
Compare
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?envoy v1.23.1 does not require patches as v1.22.2 anymore. Those patches are merged.
This also introduces a patch for catalina.