c++: provide type to std::weak_ptr template#22334
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Jul 21, 2022
Merged
c++: provide type to std::weak_ptr template#22334mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
ravenblackx
approved these changes
Jul 21, 2022
Member
|
cc @mattklein123 for final stamp |
mattklein123
approved these changes
Jul 21, 2022
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
provide type to std::weak_ptr template
Additional Description:
Most compilers do not have problems deducing type for
std::weak_ptrwithout explicit typestd::weak_ptr(shared_from_this()), but lack of the type breaks a build on macos 10.15: Homebrew/homebrew-core#105900Risk Level: Low
Testing: Use existing unit tests.
Docs Changes: No
Release Notes: No
Platform Specific Features: No