backport: c++: provide type to std::weak_ptr template #23177
Merged
wbpcode merged 1 commit intoenvoyproxy:release/v1.23from Sep 20, 2022
Merged
backport: c++: provide type to std::weak_ptr template #23177wbpcode merged 1 commit intoenvoyproxy:release/v1.23from
wbpcode merged 1 commit intoenvoyproxy:release/v1.23from
Conversation
Cherry-picked from 68aa000. Signed-off-by: Christoph Pakulski <christoph@tetrate.io> Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
6 tasks
wbpcode
approved these changes
Sep 20, 2022
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM. Thanks. And happy to see you here again. 😸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: backport: c++: provide type to std::weak_ptr template
Cherry-picked from 68aa00067bbeb7aaf13599f75e54e8837cfb13ef.
Signed-off-by: Christoph Pakulski christoph@tetrate.io
Additional Description:
This is asked by: Homebrew/homebrew-core#110883 (comment).
Risk Level: N/A
Testing: Provided
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A