envoy 1.24.0#114194
Closed
dio wants to merge 1 commit intoHomebrew:masterfrom
Closed
Conversation
BrewTestBot
added
the
automerge-skip
dio
force-pushed
the
envoy-1.24.0-update
branch
from
ea36bc5 to
c253d87
Compare
Contributor
Author
|
We do have the v1.23.2 release https://github.com/envoyproxy/envoy/releases/tag/v1.23.2. @carlocab @cho-m do you think we should aim for that (#114215) first? |
Contributor
Author
|
Seems like it requires the |
Contributor
Author
|
Thanks, @SMillerDev! Also, probably we need the |
dio
force-pushed
the
envoy-1.24.0-update
branch
from
c253d87 to
3362539
Compare
Contributor
Author
|
Sorry I needed to update one of the pre-build script args. |
dio
force-pushed
the
envoy-1.24.0-update
branch
4 times, most recently
from
61c2683 to
63cad2d
Compare
Member
yeah, always doing the latest. :) |
dio
force-pushed
the
envoy-1.24.0-update
branch
from
63cad2d to
0d72b82
Compare
Contributor
Author
|
Thanks for the confirmation @chenrui333! Really appreciated. Hope we can move this forward, with some additional labels. |
chenrui333
added
CI-linux-self-hosted
Member
|
🏃 |
Contributor
Author
|
Thank you, @chenrui333! |
cho-m
removed
the
CI-long-timeout
fxcoudert
approved these changes
Nov 13, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This supersedes #113451. This PR makes sure we build from the source code archive of a tagged release (vs. git clone) and set the build info to "Distribution" vs. "Modified" (via providing the SOURCE_VERSION file before building).