Skip to content

tests(events): migrate flaky event simulation tests to new format#649

Merged
msbrogli merged 1 commit intomasterfrom
tests/event-simulation
Jun 15, 2023
Merged

tests(events): migrate flaky event simulation tests to new format#649
msbrogli merged 1 commit intomasterfrom
tests/event-simulation

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 4, 2023

Some event tests were skipped in #646 for not working correctly. This PR reimplements those tests using the new format introduced by #647.

Acceptance Criteria

  • Remove previous event scenarios simulation tests and create new ones
  • Remove DummyMiner, as it was probably the cause for the faulty tests, and using simulator triggers is a much better approach

@glevco glevco self-assigned this Jun 4, 2023
@codecov
Copy link

codecov bot commented Jun 4, 2023

Codecov Report

Merging #649 (4605d97) into master (dd56e0a) will decrease coverage by 0.17%.
The diff coverage is 88.23%.

❗ Current head 4605d97 differs from pull request most recent head 441c255. Consider uploading reports for the commit 441c255 to get more accurate results

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   84.04%   83.87%   -0.17%     
==========================================
  Files         245      246       +1     
  Lines       20279    20340      +61     
  Branches     2757     2746      -11     
==========================================
+ Hits        17043    17061      +18     
- Misses       2639     2708      +69     
+ Partials      597      571      -26     
Impacted Files Coverage Δ
hathor/conf/settings.py 97.03% <ø> (-0.03%) ⬇️
hathor/event/model/base_event.py 100.00% <ø> (ø)
hathor/event/model/event_type.py 100.00% <ø> (ø)
hathor/event/websocket/factory.py 92.85% <ø> (ø)
hathor/p2p/sync_v1/downloader.py 83.33% <ø> (ø)
hathor/indexes/deps_index.py 90.56% <66.66%> (+0.18%) ⬆️
hathor/builder/cli_builder.py 73.95% <70.88%> (+2.45%) ⬆️
hathor/manager.py 77.21% <74.39%> (+7.43%) ⬆️
hathor/transaction/block.py 91.78% <78.94%> (+0.58%) ⬆️
hathor/builder/resources_builder.py 94.39% <95.00%> (+0.16%) ⬆️
... and 32 more

... and 10 files with indirect coverage changes

@glevco glevco force-pushed the tests/event-simulation branch from 7f331ea to 70b4556 Compare June 5, 2023 03:24
@glevco glevco changed the title tests: migrate flaky event simulation tests to new format tests(events): migrate flaky event simulation tests to new format Jun 5, 2023
@glevco glevco added the tests label Jun 5, 2023
@glevco glevco force-pushed the bugfix/ack-validation branch from 6aef466 to c949893 Compare June 5, 2023 21:14
@glevco glevco force-pushed the tests/event-simulation branch from 70b4556 to 0a62b45 Compare June 5, 2023 21:14
@glevco glevco force-pushed the bugfix/ack-validation branch from c949893 to 553915c Compare June 7, 2023 22:30
@glevco glevco force-pushed the tests/event-simulation branch 2 times, most recently from 5e114e1 to 7059ee6 Compare June 7, 2023 22:53
@glevco glevco requested review from jansegre and msbrogli June 7, 2023 22:54
@glevco glevco force-pushed the bugfix/ack-validation branch from 99cf418 to 46394ce Compare June 9, 2023 20:44
@glevco glevco force-pushed the tests/event-simulation branch from 7059ee6 to 4dc7623 Compare June 9, 2023 20:47
@glevco glevco force-pushed the bugfix/ack-validation branch from 46394ce to 373c869 Compare June 14, 2023 18:45
@glevco glevco force-pushed the tests/event-simulation branch from 4dc7623 to 90ddacc Compare June 14, 2023 19:07
@glevco glevco force-pushed the bugfix/ack-validation branch from 373c869 to 630a96b Compare June 14, 2023 20:25
@glevco glevco force-pushed the tests/event-simulation branch from 90ddacc to 8fd4a08 Compare June 14, 2023 20:26
msbrogli
msbrogli previously approved these changes Jun 15, 2023
@glevco glevco force-pushed the bugfix/ack-validation branch from 630a96b to af933bc Compare June 15, 2023 14:10
@glevco glevco force-pushed the tests/event-simulation branch from 8fd4a08 to 4605d97 Compare June 15, 2023 14:12
jansegre
jansegre previously approved these changes Jun 15, 2023
@glevco glevco force-pushed the bugfix/ack-validation branch 2 times, most recently from e1c749c to 768e9d2 Compare June 15, 2023 15:18
@glevco glevco force-pushed the tests/event-simulation branch from 4605d97 to 441c255 Compare June 15, 2023 15:21
Base automatically changed from bugfix/ack-validation to master June 15, 2023 15:22
@msbrogli msbrogli dismissed stale reviews from jansegre and themself June 15, 2023 15:22

The base branch was changed.

@glevco glevco marked this pull request as ready for review June 15, 2023 15:24
@msbrogli msbrogli merged commit 441c255 into master Jun 15, 2023
@msbrogli msbrogli deleted the tests/event-simulation branch June 15, 2023 15:25
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants