tests(events): migrate flaky event simulation tests to new format#649
Merged
tests(events): migrate flaky event simulation tests to new format#649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
- Coverage 84.04% 83.87% -0.17%
==========================================
Files 245 246 +1
Lines 20279 20340 +61
Branches 2757 2746 -11
==========================================
+ Hits 17043 17061 +18
- Misses 2639 2708 +69
+ Partials 597 571 -26
|
7f331ea to
70b4556
Compare
glevco
commented
Jun 5, 2023
This was referenced Jun 5, 2023
6aef466 to
c949893
Compare
70b4556 to
0a62b45
Compare
msbrogli
approved these changes
Jun 7, 2023
jansegre
approved these changes
Jun 7, 2023
c949893 to
553915c
Compare
5e114e1 to
7059ee6
Compare
99cf418 to
46394ce
Compare
7059ee6 to
4dc7623
Compare
46394ce to
373c869
Compare
4dc7623 to
90ddacc
Compare
373c869 to
630a96b
Compare
90ddacc to
8fd4a08
Compare
msbrogli
previously approved these changes
Jun 15, 2023
630a96b to
af933bc
Compare
8fd4a08 to
4605d97
Compare
jansegre
previously approved these changes
Jun 15, 2023
e1c749c to
768e9d2
Compare
4605d97 to
441c255
Compare
The base branch was changed.
msbrogli
approved these changes
Jun 15, 2023
jansegre
approved these changes
Jun 15, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some event tests were skipped in #646 for not working correctly. This PR reimplements those tests using the new format introduced by #647.
Acceptance Criteria
DummyMiner, as it was probably the cause for the faulty tests, and using simulator triggers is a much better approach