Conversation
glevco
force-pushed
the
chore/improve-progress
branch
from
c4c450e to
ef3520b
Compare
jansegre
previously approved these changes
Jun 5, 2023
jansegre
previously approved these changes
Jun 6, 2023
msbrogli
previously approved these changes
Jun 7, 2023
glevco
force-pushed
the
chore/improve-progress
branch
from
2814a87 to
69151c0
Compare
jansegre
reviewed
Jun 7, 2023
jansegre
approved these changes
Jun 7, 2023
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
- Coverage 84.08% 84.05% -0.04%
==========================================
Files 245 245
Lines 20284 20286 +2
Branches 2757 2757
==========================================
- Hits 17056 17051 -5
- Misses 2632 2638 +6
- Partials 596 597 +1
|
msbrogli
approved these changes
Jun 9, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
progressfunction frompartial_rocksdb_tips_index.pytoutil.py, making it genericprogressfunction, solving TODO