Skip to content

tests(events): migrate flaky event simulation tests to new format #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msbrogli merged 1 commit into from
Jun 15, 2023
Merged

tests(events): migrate flaky event simulation tests to new format #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 0 additions & 73 deletions hathor/simulator/miner/dummy_miner.py
View file
Open in desktop
Comment thread
msbrogli marked this conversation as resolved.

This file was deleted.

4 changes: 0 additions & 4 deletions hathor/simulator/simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
from hathor.daa import TestMode, _set_test_mode
from hathor.manager import HathorManager
from hathor.simulator.clock import HeapClock
from hathor.simulator.miner.dummy_miner import DummyMiner
from hathor.simulator.miner.geometric_miner import GeometricMiner
from hathor.simulator.tx_generator import RandomTransactionGenerator
from hathor.transaction.genesis import _get_genesis_transactions_unsafe
Expand Down Expand Up @@ -193,9 +192,6 @@ def create_tx_generator(self, peer: HathorManager, *args: Any, **kwargs: Any) ->
def create_miner(self, peer: HathorManager, *args: Any, **kwargs: Any) -> GeometricMiner:
return GeometricMiner(peer, self.rng, *args, **kwargs)

def create_dummy_miner(self, peer: HathorManager, *args: Any, **kwargs: Any) -> DummyMiner:
return DummyMiner(peer, self.rng, *args, **kwargs)

def run_to_completion(self):
""" This will advance the test's clock until all calls scheduled are done.
"""
Expand Down
3 changes: 2 additions & 1 deletion tests/event/event_simulation_tester.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ def _create_artifacts(self) -> None:
.enable_event_queue()
artifacts = self.simulator.create_artifacts(builder)

self.peer_id = peer_id.id
assert peer_id.id is not None
self.peer_id: str = peer_id.id
self.manager = artifacts.manager
self.manager.allow_mining_without_peers()
self.settings = artifacts.settings
Expand Down
Loading