fix(events): fix bugs in the event stream and improve tests#647
Merged
fix(events): fix bugs in the event stream and improve tests#647
Conversation
edf981b to
b80e4c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
- Coverage 83.88% 83.85% -0.04%
==========================================
Files 247 247
Lines 20376 20378 +2
Branches 2748 2748
==========================================
- Hits 17093 17088 -5
- Misses 2709 2714 +5
- Partials 574 576 +2
|
cdbf5ee to
6aef466
Compare
d3f58e0 to
347472d
Compare
6aef466 to
c949893
Compare
msbrogli
previously approved these changes
Jun 7, 2023
347472d to
99c47b4
Compare
c949893 to
553915c
Compare
99cf418 to
46394ce
Compare
jansegre
previously approved these changes
Jun 12, 2023
Member
jansegre
left a comment
There was a problem hiding this comment.
Just a small note, we normally use fix instead of bugfix for both branch prefix and the commit message.
373c869 to
630a96b
Compare
msbrogli
approved these changes
Jun 14, 2023
630a96b to
af933bc
Compare
jansegre
approved these changes
Jun 15, 2023
af933bc to
e1c749c
Compare
e1c749c to
768e9d2
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
EventDataand add tests for itEventWebsocketProtocoland add tests for themBaseEventSimulationTesterto help writing event queue feature tests, and new tests using it