Skip to content

fix(events): fix bugs in the event stream and improve tests#647

Merged
msbrogli merged 1 commit intomasterfrom
bugfix/ack-validation
Jun 15, 2023
Merged

fix(events): fix bugs in the event stream and improve tests#647
msbrogli merged 1 commit intomasterfrom
bugfix/ack-validation

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented Jun 2, 2023

Acceptance Criteria

  • Add missing docstrings and typings
  • Fix parsing bug in EventData and add tests for it
  • Fix edge cases bugs in EventWebsocketProtocol and add tests for them
  • Implement BaseEventSimulationTester to help writing event queue feature tests, and new tests using it

@glevco glevco self-assigned this Jun 2, 2023
@glevco glevco force-pushed the bugfix/ack-validation branch from edf981b to b80e4c1 Compare June 2, 2023 14:57
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #647 (af933bc) into master (7ac143f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head af933bc differs from pull request most recent head 768e9d2. Consider uploading reports for the commit 768e9d2 to get more accurate results

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   83.88%   83.85%   -0.04%     
==========================================
  Files         247      247              
  Lines       20376    20378       +2     
  Branches     2748     2748              
==========================================
- Hits        17093    17088       -5     
- Misses       2709     2714       +5     
- Partials      574      576       +2     
Impacted Files Coverage Δ
hathor/event/model/base_event.py 100.00% <ø> (ø)
hathor/event/model/event_type.py 100.00% <ø> (ø)
hathor/event/websocket/factory.py 92.85% <ø> (ø)
hathor/builder/builder.py 92.99% <100.00%> (+0.01%) ⬆️
hathor/event/event_manager.py 91.74% <100.00%> (+0.07%) ⬆️
hathor/event/model/event_data.py 100.00% <100.00%> (ø)
hathor/event/websocket/protocol.py 95.83% <100.00%> (ø)

... and 6 files with indirect coverage changes

@glevco glevco force-pushed the bugfix/ack-validation branch 5 times, most recently from cdbf5ee to 6aef466 Compare June 5, 2023 03:19
@glevco glevco changed the base branch from master to feat/feature-activation/caching-mechanism June 5, 2023 03:23
@glevco glevco changed the title Bugfix/ack validation bugfix(events): fix bugs in the event stream and improve tests Jun 5, 2023
@glevco glevco added bug Something isn't working tests labels Jun 5, 2023
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from d3f58e0 to 347472d Compare June 5, 2023 21:12
@glevco glevco force-pushed the bugfix/ack-validation branch from 6aef466 to c949893 Compare June 5, 2023 21:14
msbrogli
msbrogli previously approved these changes Jun 7, 2023
@glevco glevco force-pushed the feat/feature-activation/caching-mechanism branch from 347472d to 99c47b4 Compare June 7, 2023 21:13
@glevco glevco force-pushed the bugfix/ack-validation branch from c949893 to 553915c Compare June 7, 2023 22:30
@glevco glevco changed the base branch from feat/feature-activation/caching-mechanism to master June 7, 2023 22:31
@glevco glevco dismissed msbrogli’s stale review June 7, 2023 22:31

The base branch was changed.

@glevco glevco marked this pull request as ready for review June 7, 2023 22:38
@glevco glevco requested a review from jansegre as a code owner June 7, 2023 22:38
@glevco glevco requested a review from msbrogli June 7, 2023 22:40
@glevco glevco force-pushed the bugfix/ack-validation branch from 99cf418 to 46394ce Compare June 9, 2023 20:44
jansegre
jansegre previously approved these changes Jun 12, 2023
Copy link
Member

@jansegre jansegre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small note, we normally use fix instead of bugfix for both branch prefix and the commit message.

@glevco glevco changed the title bugfix(events): fix bugs in the event stream and improve tests fix(events): fix bugs in the event stream and improve tests Jun 12, 2023
@glevco glevco force-pushed the bugfix/ack-validation branch 2 times, most recently from 373c869 to 630a96b Compare June 14, 2023 20:25
@glevco glevco force-pushed the bugfix/ack-validation branch from 630a96b to af933bc Compare June 15, 2023 14:10
@glevco glevco force-pushed the bugfix/ack-validation branch from af933bc to e1c749c Compare June 15, 2023 15:17
@glevco glevco force-pushed the bugfix/ack-validation branch from e1c749c to 768e9d2 Compare June 15, 2023 15:18
@msbrogli msbrogli merged commit 768e9d2 into master Jun 15, 2023
@msbrogli msbrogli deleted the bugfix/ack-validation branch June 15, 2023 15:22
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working tests

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants