Skip to content

feat(feature-activation): implement feature service#639

Merged
jansegre merged 1 commit intomasterfrom
feat/feature-activation/feature-service
May 31, 2023
Merged

feat(feature-activation): implement feature service#639
jansegre merged 1 commit intomasterfrom
feat/feature-activation/feature-service

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 30, 2023

Depends on #623

This is an exact copy of #613, since it was merged in the incorrect order and reverted.

Acceptance Criteria

  • Implement Block.get_feature_activation_bits() method and tests
  • Implement FeatureService class and tests

@glevco glevco requested a review from jansegre as a code owner May 30, 2023 19:52
@glevco glevco self-assigned this May 30, 2023
@glevco glevco requested a review from msbrogli as a code owner May 30, 2023 19:52
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 64baf0c to dfd7755 Compare May 30, 2023 19:54
@glevco glevco force-pushed the feat/feature-activation/feature-service branch from 60abb03 to 2656f25 Compare May 30, 2023 19:55
jansegre
jansegre previously approved these changes May 30, 2023
msbrogli
msbrogli previously approved these changes May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #639 (7a84f43) into master (e80309e) will increase coverage by 0.04%.
The diff coverage is 97.75%.

❗ Current head 7a84f43 differs from pull request most recent head cf1a728. Consider uploading reports for the commit cf1a728 to get more accurate results

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   83.93%   83.97%   +0.04%     
==========================================
  Files         241      243       +2     
  Lines       20134    20223      +89     
  Branches     2742     2757      +15     
==========================================
+ Hits        16899    16982      +83     
- Misses       2638     2640       +2     
- Partials      597      601       +4     
Impacted Files Coverage Δ
hathor/feature_activation/feature_service.py 97.26% <97.26%> (ø)
...or/feature_activation/model/feature_description.py 100.00% <100.00%> (ø)
hathor/transaction/block.py 91.19% <100.00%> (+0.48%) ⬆️

... and 5 files with indirect coverage changes

Base automatically changed from feat/feature-activation/signal-bits to master May 31, 2023 02:41
@glevco glevco dismissed stale reviews from msbrogli and jansegre via 7a84f43 May 31, 2023 02:51
@glevco glevco force-pushed the feat/feature-activation/feature-service branch from 2656f25 to 7a84f43 Compare May 31, 2023 02:51
@glevco glevco force-pushed the feat/feature-activation/feature-service branch from 7a84f43 to cf1a728 Compare May 31, 2023 04:34
@jansegre jansegre merged commit c68cc37 into master May 31, 2023
@jansegre jansegre deleted the feat/feature-activation/feature-service branch May 31, 2023 13:18
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants