feat(feature-activation): implement signal_bits field in txs#623
Merged
feat(feature-activation): implement signal_bits field in txs#623
Conversation
1002823 to
6dbf1da
Compare
glevco
commented
May 22, 2023
glevco
commented
May 22, 2023
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
==========================================
- Coverage 83.94% 83.92% -0.03%
==========================================
Files 241 241
Lines 20128 20134 +6
Branches 2743 2742 -1
==========================================
+ Hits 16896 16897 +1
- Misses 2636 2638 +2
- Partials 596 599 +3
|
msbrogli
requested changes
May 22, 2023
6dbf1da to
80814b3
Compare
msbrogli
requested changes
May 23, 2023
92faeaa to
889d65c
Compare
jansegre
requested changes
May 24, 2023
889d65c to
13a6512
Compare
msbrogli
previously approved these changes
May 25, 2023
jansegre
previously approved these changes
May 30, 2023
60abb03 to
64baf0c
Compare
64baf0c to
dfd7755
Compare
jansegre
approved these changes
May 30, 2023
msbrogli
approved these changes
May 30, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
TxVersionenum so it fails instantiation for values larger than one byte, instead of ignoring it.signal_bitsattribute inBaseTransaction, derived from the first byte of theversionfield.ATTENTION: this PR touches important parts of the code