Skip to content

feat(feature-activation): implement signal_bits field in txs#623

Merged
glevco merged 4 commits intomasterfrom
feat/feature-activation/signal-bits
May 31, 2023
Merged

feat(feature-activation): implement signal_bits field in txs#623
glevco merged 4 commits intomasterfrom
feat/feature-activation/signal-bits

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 22, 2023

Acceptance Criteria

  • Change TxVersion enum so it fails instantiation for values larger than one byte, instead of ignoring it.
  • Create new signal_bits attribute in BaseTransaction, derived from the first byte of the version field.

ATTENTION: this PR touches important parts of the code

@glevco glevco self-assigned this May 22, 2023
@glevco glevco requested review from jansegre and msbrogli as code owners May 22, 2023 00:32
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 1002823 to 6dbf1da Compare May 22, 2023 00:40
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #623 (dfd7755) into master (b01ab74) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
- Coverage   83.94%   83.92%   -0.03%     
==========================================
  Files         241      241              
  Lines       20128    20134       +6     
  Branches     2743     2742       -1     
==========================================
+ Hits        16896    16897       +1     
- Misses       2636     2638       +2     
- Partials      596      599       +3     
Impacted Files Coverage Δ
hathor/transaction/base_transaction.py 91.28% <100.00%> (+0.03%) ⬆️
hathor/transaction/block.py 90.71% <100.00%> (+0.05%) ⬆️
hathor/transaction/merge_mined_block.py 76.74% <100.00%> (ø)
hathor/transaction/token_creation_tx.py 99.30% <100.00%> (+<0.01%) ⬆️
hathor/transaction/transaction.py 92.66% <100.00%> (+0.02%) ⬆️

... and 3 files with indirect coverage changes

@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 6dbf1da to 80814b3 Compare May 23, 2023 15:45
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 92faeaa to 889d65c Compare May 23, 2023 20:02
@glevco glevco requested a review from msbrogli May 23, 2023 20:02
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 889d65c to 13a6512 Compare May 24, 2023 21:54
@glevco glevco requested a review from jansegre May 25, 2023 04:24
msbrogli
msbrogli previously approved these changes May 25, 2023
jansegre
jansegre previously approved these changes May 30, 2023
@glevco glevco dismissed stale reviews from jansegre and msbrogli via 60abb03 May 30, 2023 19:30
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 60abb03 to 64baf0c Compare May 30, 2023 19:51
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 64baf0c to dfd7755 Compare May 30, 2023 19:54
@glevco glevco requested review from jansegre and msbrogli May 30, 2023 19:58
@glevco glevco merged commit e80309e into master May 31, 2023
@glevco glevco deleted the feat/feature-activation/signal-bits branch May 31, 2023 02:41
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants