Skip to content

feat(feature-activation): implement feature service#613

Merged
glevco merged 11 commits intofeat/feature-activation/signal-bitsfrom
feat/feature-activation/feature-service
May 30, 2023
Merged

feat(feature-activation): implement feature service#613
glevco merged 11 commits intofeat/feature-activation/signal-bitsfrom
feat/feature-activation/feature-service

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 16, 2023

Acceptance Criteria

  • Implement Block.get_feature_activation_bits() method and tests
  • Implement FeatureService class and tests

@glevco glevco self-assigned this May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #613 (537e883) into feat/feature-activation/signal-bits (64baf0c) will increase coverage by 0.09%.
The diff coverage is 97.75%.

@@                           Coverage Diff                           @@
##           feat/feature-activation/signal-bits     #613      +/-   ##
=======================================================================
+ Coverage                                83.90%   83.99%   +0.09%     
=======================================================================
  Files                                      240      242       +2     
  Lines                                    20132    20221      +89     
  Branches                                  2742     2757      +15     
=======================================================================
+ Hits                                     16892    16985      +93     
+ Misses                                    2640     2637       -3     
+ Partials                                   600      599       -1     
Impacted Files Coverage Δ
hathor/feature_activation/feature_service.py 97.26% <97.26%> (ø)
...or/feature_activation/model/feature_description.py 100.00% <100.00%> (ø)
hathor/transaction/block.py 91.19% <100.00%> (+0.48%) ⬆️

... and 3 files with indirect coverage changes

@glevco glevco force-pushed the feat/feature-activation/feature-service branch from 99f82b7 to a32f415 Compare May 16, 2023 22:52
@glevco glevco changed the base branch from master to refactor/remove-old-settings May 16, 2023 22:53
@glevco glevco force-pushed the refactor/remove-old-settings branch from 3ba9fcb to e1a229e Compare May 17, 2023 19:26
@glevco glevco force-pushed the feat/feature-activation/feature-service branch 3 times, most recently from c197a89 to 9ea59d8 Compare May 22, 2023 01:53
@glevco glevco changed the base branch from refactor/remove-old-settings to feat/feature-activation/basic-structures May 22, 2023 18:04
@glevco glevco force-pushed the feat/feature-activation/basic-structures branch from 2b6cd22 to 44615a2 Compare May 23, 2023 16:05
Base automatically changed from feat/feature-activation/basic-structures to master May 23, 2023 20:00
@glevco glevco force-pushed the feat/feature-activation/feature-service branch from 9ea59d8 to 2b021f1 Compare May 24, 2023 04:42
@glevco glevco changed the base branch from master to chore/yaml-inheritance May 24, 2023 04:43
@glevco glevco changed the base branch from chore/yaml-inheritance to feat/feature-activation/signal-bits May 24, 2023 04:43
@glevco glevco changed the base branch from feat/feature-activation/signal-bits to master May 24, 2023 04:43
@glevco glevco force-pushed the feat/feature-activation/feature-service branch from a942af9 to a26d111 Compare May 24, 2023 21:54
@glevco glevco changed the base branch from master to feat/feature-activation/signal-bits May 24, 2023 21:55
@glevco glevco force-pushed the feat/feature-activation/feature-service branch from a26d111 to cc28ad9 Compare May 25, 2023 04:23
@glevco glevco marked this pull request as ready for review May 25, 2023 04:37
@glevco glevco requested review from jansegre and msbrogli as code owners May 25, 2023 04:37
@glevco glevco requested a review from msbrogli May 25, 2023 19:57
@glevco glevco merged commit 60abb03 into feat/feature-activation/signal-bits May 30, 2023
@glevco glevco deleted the feat/feature-activation/feature-service branch May 30, 2023 19:30
@glevco glevco restored the feat/feature-activation/feature-service branch May 30, 2023 19:34
glevco added a commit that referenced this pull request May 30, 2023
@glevco glevco deleted the feat/feature-activation/feature-service branch May 30, 2023 19:35
@msbrogli
Copy link
Member

This PR was merged into the wrong branch. The changes were reversed and a new PR was created here: #639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants