feat(feature-activation): bit count optimization#633
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 83.97% 83.63% -0.35%
==========================================
Files 245 246 +1
Lines 20299 20339 +40
Branches 2763 2767 +4
==========================================
- Hits 17047 17011 -36
- Misses 2657 2742 +85
+ Partials 595 586 -9
|
Base automatically changed from
feat/feature-activation/feature-service
to
feat/feature-activation/signal-bits
May 30, 2023 19:30
64baf0c to
dfd7755
Compare
09725e2 to
5cf821f
Compare
7a84f43 to
cf1a728
Compare
Base automatically changed from
feat/feature-activation/feature-service
to
master
May 31, 2023 13:18
f61e868 to
a0db26c
Compare
msbrogli
previously approved these changes
Jun 5, 2023
msbrogli
previously approved these changes
Jun 7, 2023
8a97f48 to
3008ef3
Compare
msbrogli
previously approved these changes
Jun 9, 2023
3008ef3 to
2de80c1
Compare
jansegre
approved these changes
Jun 12, 2023
msbrogli
approved these changes
Jun 13, 2023
2de80c1 to
a71cd1b
Compare
a71cd1b to
0bc0df8
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the suggestion in #613 (comment)
Acceptance Criteria
get_bit_list()utils functionTransactionMetadata.feature_activation_bit_countsattributeBaseTransaction.calculate_feature_activation_bit_counts()abstract method and concrete implementations onBlockandTransactionfeature_activation_bit_countstoBaseTransaction.get_metadata()andBaseTransaction.update_initial_metadata()FeatureServiceto use thefeature_activation_bit_countsmetadata attribute instead of calculating the bit count itself