Skip to content

feat(feature-activation): bit count optimization#633

Merged
glevco merged 3 commits intomasterfrom
feat/feature-activation/bit-count-optimization
Jun 14, 2023
Merged

feat(feature-activation): bit count optimization#633
glevco merged 3 commits intomasterfrom
feat/feature-activation/bit-count-optimization

Conversation

@glevco
Copy link
Contributor

@glevco glevco commented May 26, 2023

Implements the suggestion in #613 (comment)

Acceptance Criteria

  • Implement new get_bit_list() utils function
  • Create new TransactionMetadata.feature_activation_bit_counts attribute
  • Implement new BaseTransaction.calculate_feature_activation_bit_counts() abstract method and concrete implementations on Block and Transaction
  • Add feature_activation_bit_counts to BaseTransaction.get_metadata() and BaseTransaction.update_initial_metadata()
  • Update FeatureService to use the feature_activation_bit_counts metadata attribute instead of calculating the bit count itself

@glevco glevco self-assigned this May 26, 2023
@glevco glevco changed the base branch from master to feat/feature-activation/feature-service May 26, 2023 16:27
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #633 (0bc0df8) into master (f8796eb) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   83.97%   83.63%   -0.35%     
==========================================
  Files         245      246       +1     
  Lines       20299    20339      +40     
  Branches     2763     2767       +4     
==========================================
- Hits        17047    17011      -36     
- Misses       2657     2742      +85     
+ Partials      595      586       -9     
Impacted Files Coverage Δ
hathor/conf/unittests.py 100.00% <100.00%> (ø)
hathor/feature_activation/feature_service.py 96.82% <100.00%> (-0.44%) ⬇️
hathor/transaction/base_transaction.py 91.45% <100.00%> (+0.01%) ⬆️
hathor/transaction/block.py 92.05% <100.00%> (+0.86%) ⬆️
hathor/transaction/transaction_metadata.py 90.68% <100.00%> (+0.23%) ⬆️
hathor/utils/int.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

@glevco glevco marked this pull request as ready for review May 26, 2023 22:14
@glevco glevco requested review from jansegre and msbrogli as code owners May 26, 2023 22:14
Base automatically changed from feat/feature-activation/feature-service to feat/feature-activation/signal-bits May 30, 2023 19:30
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch 2 times, most recently from 64baf0c to dfd7755 Compare May 30, 2023 19:54
@glevco glevco changed the base branch from feat/feature-activation/signal-bits to feat/feature-activation/feature-service May 30, 2023 20:16
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from 09725e2 to 5cf821f Compare May 30, 2023 20:20
@glevco glevco force-pushed the feat/feature-activation/feature-service branch 2 times, most recently from 7a84f43 to cf1a728 Compare May 31, 2023 04:34
Base automatically changed from feat/feature-activation/feature-service to master May 31, 2023 13:18
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch 3 times, most recently from f61e868 to a0db26c Compare June 2, 2023 03:20
msbrogli
msbrogli previously approved these changes Jun 5, 2023
msbrogli
msbrogli previously approved these changes Jun 7, 2023
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from 8a97f48 to 3008ef3 Compare June 7, 2023 15:55
@glevco glevco requested a review from msbrogli June 7, 2023 15:56
msbrogli
msbrogli previously approved these changes Jun 9, 2023
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from 3008ef3 to 2de80c1 Compare June 9, 2023 20:21
@glevco glevco requested a review from msbrogli June 9, 2023 20:21
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from 2de80c1 to a71cd1b Compare June 13, 2023 22:12
@glevco glevco force-pushed the feat/feature-activation/bit-count-optimization branch from a71cd1b to 0bc0df8 Compare June 13, 2023 22:30
@glevco glevco merged commit 33daa68 into master Jun 14, 2023
@glevco glevco deleted the feat/feature-activation/bit-count-optimization branch June 14, 2023 01:01
@jansegre jansegre mentioned this pull request Jul 12, 2023
2 tasks
This was referenced Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants