refactor: move hathor settings to yaml configuration files [part 2/2]#597
refactor: move hathor settings to yaml configuration files [part 2/2]#597glevco wants to merge 4 commits intorefactor/settingsfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## refactor/settings #597 +/- ##
====================================================
Coverage ? 83.63%
====================================================
Files ? 229
Lines ? 19667
Branches ? 2695
====================================================
Hits ? 16448
Misses ? 2621
Partials ? 598 |
0353479 to
fec0177
Compare
fec0177 to
02dcf9e
Compare
02dcf9e to
a123809
Compare
jansegre
left a comment
There was a problem hiding this comment.
The changes seem correct. But I would prefer to either hold them off for 0.55.0 (instead of 0.54.0 which is on track to have YAML settings support), or have a better mechanism for steering people to the correct way to use settings if they are using the old mechanism (mentioned here).
662a06b to
6e0ded5
Compare
a123809 to
f2a7bee
Compare
3ba9fcb to
e1a229e
Compare
Backwards compatibility has been added as explained in #593 (comment). But if people are inheriting from our python modules, I agree we should not delete them in a transitioning release. What do you think should be done with this PR? Should I close it and reopen when it's time, or do we just leave it here, waiting? |
|
I'm closing this PR and moving it to the Parking Lot. We'll release the backwards compatible version in #593 , and eventually reopen this one when we are sure the python modules can be removed. |
Depends on #593
Acceptance Criteria