Conversation
1 task
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
c66ad17 to
eaef7cd
Compare
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
eaef7cd to
e0a08c0
Compare
glevco
force-pushed
the
feat/critical-indexes
branch
from
452fd4a to
2199ef8
Compare
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
e0a08c0 to
38ae478
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
- Coverage 85.85% 85.71% -0.15%
==========================================
Files 439 439
Lines 33758 33767 +9
Branches 5276 5277 +1
==========================================
- Hits 28984 28944 -40
- Misses 3773 3805 +32
- Partials 1001 1018 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
38ae478 to
6fc3b8b
Compare
msbrogli
requested changes
Jan 21, 2026
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
glevco
force-pushed
the
feat/critical-indexes
branch
2 times, most recently
from
00e1894 to
945a67f
Compare
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
6fc3b8b to
6bf9bd3
Compare
|
Bencher Report| Branch | refactor/wallet-on-new-tx |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.70 m(-1.13%)Baseline: 1.71 m | 1.54 m (91.03%) | 2.06 m (82.39%) |
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
4 times, most recently
from
dae0a35 to
deb4dca
Compare
glevco
force-pushed
the
refactor/wallet-on-new-tx
branch
from
deb4dca to
0e8fa62
Compare
msbrogli
approved these changes
Jan 28, 2026
jansegre
approved these changes
Jan 28, 2026
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
2 tasks
r4mmer
added a commit
that referenced
this pull request
Jan 29, 2026
* origin/master: chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor feat(script): deprecate unnecessary opcodes test: Fix flaky tests refactor(nano): Refactor to facilitate dry runnning blocks and transactions feat(nano): add support for json_dumps (#1572) refactor(nano): Move the nano execution logic to a separate file
jansegre
pushed a commit
that referenced
this pull request
Jan 30, 2026
r4mmer
added a commit
that referenced
this pull request
Feb 19, 2026
…ntic-settings * origin/master: chore: adjust testnet config for v0.69.0 release chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor
r4mmer
added a commit
that referenced
this pull request
Feb 24, 2026
…print-move-1 * origin/master: feat: pydantic settings (#1600) fix[thin_wallet]: handle address history invalid tx version (#1590) refactor(nano): Make NCBlockExecutor a pure executor with no side effects fix[nginx]: Make sure we trust the GCP IPs to get the real client IP (#1595) refactor: Upgrade to Pydantic v2 chore(github): Split GitHub main action into lint, test-cli, test-lib, test-other fix[nginx]: Use a larger buffer size for /v1a/status (#1594) chore: adjust testnet config for v0.69.0 release chore[storage]: Limit the total size of RocksDB WAL files (#1518) chore: adjust testnet config for v0.69.0 release chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1547
Motivation
There's a long-standing TODO on the
VertexHandlerto make the wallet processing of new txs asynchronous, via PubSub. This PR does this. I had to introduce a new event type to fire before the consensus, because the wallet expected itson_new_txmethod to be called before all other asynchronous events the consensus emits.Acceptance Criteria
NETWORK_NEW_TX_PROCESSING.walleton theVertexHandlerso it handlesNETWORK_NEW_TX_PROCESSINGevents asynchronously, instead of a synchronous call towallet.on_new_tx().Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged