Skip to content

fix[thin_wallet]: handle address history invalid tx version#1590

Merged
luislhl merged 2 commits intomasterfrom
fix/thin_wallet/address-history-invalid-tx-version
Feb 19, 2026
Merged

fix[thin_wallet]: handle address history invalid tx version#1590
luislhl merged 2 commits intomasterfrom
fix/thin_wallet/address-history-invalid-tx-version

Conversation

@luislhl
Copy link
Contributor

@luislhl luislhl commented Feb 3, 2026

Motivation

There is an exception not treated when an user inputs invalid tx version in the /address_history endpoint: https://hathor.app.opsgenie.com/alert/detail/6b7fd5dd-05d4-4347-b334-54f662c64fda-1769746499423/details

Acceptance Criteria

  • We should capture the exception and return an error response without raising an exception

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@luislhl luislhl self-assigned this Feb 3, 2026
@luislhl luislhl moved this from Todo to In Progress (Done) in Hathor Network Feb 3, 2026
@luislhl luislhl requested a review from raul-oliveira February 3, 2026 13:34
@luislhl luislhl force-pushed the fix/thin_wallet/address-history-invalid-tx-version branch from 58c9fbe to c966f68 Compare February 3, 2026 13:37
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🐰 Bencher Report

Branchfix/thin_wallet/address-history-invalid-tx-version
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.67 m
(-2.43%)Baseline: 1.71 m
1.54 m
(92.24%)
2.06 m
(81.31%)
🐰 View full continuous benchmarking report in Bencher

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.72%. Comparing base (a98679e) to head (2a9bd2b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...or/wallet/resources/thin_wallet/address_history.py 83.33% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1590      +/-   ##
==========================================
+ Coverage   85.68%   85.72%   +0.03%     
==========================================
  Files         442      442              
  Lines       33846    33862      +16     
  Branches     5293     5297       +4     
==========================================
+ Hits        29000    29027      +27     
+ Misses       3824     3817       -7     
+ Partials     1022     1018       -4     
Flag Coverage Δ
test-lib 85.72% <83.33%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@raul-oliveira raul-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both error responses return 200 with success: False. Consider returning 400 Bad Request for invalid parameters, which is more semantically correct for client errors.

@luislhl luislhl moved this from In Progress (Done) to In Review (WIP) in Hathor Network Feb 6, 2026
@luislhl luislhl requested a review from glevco February 12, 2026 21:25
@luislhl luislhl force-pushed the fix/thin_wallet/address-history-invalid-tx-version branch from 656b257 to 8807240 Compare February 12, 2026 21:29
@msbrogli msbrogli force-pushed the master branch 2 times, most recently from eb416fa to 21d7909 Compare February 12, 2026 23:12
@luislhl luislhl moved this from In Review (WIP) to In Review (Done) in Hathor Network Feb 13, 2026
@luislhl luislhl force-pushed the fix/thin_wallet/address-history-invalid-tx-version branch from 8807240 to e107069 Compare February 13, 2026 14:29
@github-project-automation github-project-automation bot moved this from In Review (Done) to In Review (WIP) in Hathor Network Feb 18, 2026
@luislhl luislhl force-pushed the fix/thin_wallet/address-history-invalid-tx-version branch from e107069 to 2a9bd2b Compare February 19, 2026 16:19
@luislhl luislhl enabled auto-merge (squash) February 19, 2026 16:19
@luislhl luislhl moved this from In Review (WIP) to In Review (Done) in Hathor Network Feb 19, 2026
@luislhl luislhl merged commit 23f26ca into master Feb 19, 2026
32 checks passed
@luislhl luislhl deleted the fix/thin_wallet/address-history-invalid-tx-version branch February 19, 2026 16:40
@github-project-automation github-project-automation bot moved this from In Review (Done) to Waiting to be deployed in Hathor Network Feb 19, 2026
r4mmer added a commit that referenced this pull request Feb 24, 2026
…' into feat/hathorlib-pydantic-settings

* origin/feat/hathorlib-pydantic-settings:
  fix[thin_wallet]: handle address history invalid tx version (#1590)
r4mmer added a commit that referenced this pull request Feb 24, 2026
…print-move-1

* origin/master:
  feat: pydantic settings (#1600)
  fix[thin_wallet]: handle address history invalid tx version (#1590)
  refactor(nano): Make NCBlockExecutor a pure executor with no side effects
  fix[nginx]: Make sure we trust the GCP IPs to get the real client IP (#1595)
  refactor: Upgrade to Pydantic v2
  chore(github): Split GitHub main action into lint, test-cli, test-lib, test-other
  fix[nginx]: Use a larger buffer size for /v1a/status (#1594)
  chore: adjust testnet config for v0.69.0 release
  chore[storage]: Limit the total size of RocksDB WAL files (#1518)
  chore: adjust testnet config for v0.69.0 release
  chore: configure feature activations for v0.69.0 release
  refactor: wallet on_new_tx (#1561)
  refactor(nano): Remove dead reorg cleanup code from block executor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting to be deployed

Development

Successfully merging this pull request may close these issues.

4 participants