Merged
Conversation
|
Bencher Report| Branch | feat/hathorlib-pydantic-settings |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.55 m(-9.65%)Baseline: 1.71 m | 1.54 m (99.61%) | 2.05 m (75.29%) |
r4mmer
commented
Feb 19, 2026
…ntic-settings * origin/master: chore: adjust testnet config for v0.69.0 release chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
- Coverage 85.81% 85.68% -0.13%
==========================================
Files 442 439 -3
Lines 33862 33618 -244
Branches 5297 5282 -15
==========================================
- Hits 29058 28807 -251
- Misses 3793 3797 +4
- Partials 1011 1014 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jansegre
previously approved these changes
Feb 19, 2026
msbrogli
approved these changes
Feb 19, 2026
msbrogli
previously approved these changes
Feb 20, 2026
…' into feat/hathorlib-pydantic-settings * origin/feat/hathorlib-pydantic-settings: fix[thin_wallet]: handle address history invalid tx version (#1590)
msbrogli
approved these changes
Feb 24, 2026
jansegre
approved these changes
Feb 24, 2026
github-project-automation
bot
moved this from In Review (Done)
to In Review (WIP)
in Hathor Network
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
r4mmer
added a commit
that referenced
this pull request
Feb 24, 2026
…print-move-1 * origin/master: feat: pydantic settings (#1600) fix[thin_wallet]: handle address history invalid tx version (#1590) refactor(nano): Make NCBlockExecutor a pure executor with no side effects fix[nginx]: Make sure we trust the GCP IPs to get the real client IP (#1595) refactor: Upgrade to Pydantic v2 chore(github): Split GitHub main action into lint, test-cli, test-lib, test-other fix[nginx]: Use a larger buffer size for /v1a/status (#1594) chore: adjust testnet config for v0.69.0 release chore[storage]: Limit the total size of RocksDB WAL files (#1518) chore: adjust testnet config for v0.69.0 release chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The unification of the hathor and hathorlib settings was made a pre-requisite (ref) to merge #1592
Acceptance Criteria
Note
hathorlib now supporpts yaml settings through
HATHOR_CONFIG_YAMLWarning
Beaking change: Moved hathorlib settings envvar from
TXMINING_CONFIG_FILEtoHATHOR_CONFIG_FILEorHATHOR_CONFIG_YAMLif using yaml settingsChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged