feat(nano): add support for json_dumps#1572
Merged
Conversation
glevco
force-pushed
the
feat/nano/json-dumps
branch
from
3558fe8 to
66ff723
Compare
|
Bencher Report| Branch | feat/nano/json-dumps |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(-2.24%)Baseline: 1.72 m | 1.54 m (92.06%) | 2.06 m (81.47%) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
- Coverage 86.34% 86.26% -0.09%
==========================================
Files 439 439
Lines 33690 33699 +9
Branches 5271 5273 +2
==========================================
- Hits 29091 29070 -21
- Misses 3596 3618 +22
- Partials 1003 1011 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
msbrogli
previously approved these changes
Jan 23, 2026
glevco
commented
Jan 23, 2026
msbrogli
approved these changes
Jan 23, 2026
msbrogli
previously approved these changes
Jan 23, 2026
glevco
force-pushed
the
feat/nano/json-dumps
branch
from
4c30fe1 to
1e1518c
Compare
glevco
force-pushed
the
feat/nano/json-dumps
branch
from
1e1518c to
143a655
Compare
msbrogli
approved these changes
Jan 26, 2026
jansegre
approved these changes
Jan 26, 2026
glevco
force-pushed
the
feat/nano/json-dumps
branch
from
143a655 to
63509d6
Compare
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
2 tasks
r4mmer
added a commit
that referenced
this pull request
Jan 29, 2026
* origin/master: chore: configure feature activations for v0.69.0 release refactor: wallet on_new_tx (#1561) refactor(nano): Remove dead reorg cleanup code from block executor feat(script): deprecate unnecessary opcodes test: Fix flaky tests refactor(nano): Refactor to facilitate dry runnning blocks and transactions feat(nano): add support for json_dumps (#1572) refactor(nano): Move the nano execution logic to a separate file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There's no easy way to call
emit_eventwith json data in Blueprints. This PR adds support forjson_dumpsto fix this.Acceptance Criteria
json_dumpsin nano. The provided function supports a subset of arguments of Python'sjson.dumps.FEE_TOKENSfeature to become active, before approving OCBs that usejson_dumps.datapassed toemit_eventisbytes.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged