Skip to content

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Sep 6, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj self-assigned this Sep 6, 2024
@gryczj gryczj requested review from a team as code owners September 6, 2024 12:56
@snippet-bot
Copy link

snippet-bot bot commented Sep 6, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Sep 6, 2024
@gryczj gryczj changed the title Compute reservations feat: compute reservations Sep 6, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 6, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 6, 2024
@gryczj gryczj force-pushed the compute_reservations branch from 776acce to a5db741 Compare September 6, 2024 12:57
@gryczj gryczj changed the title feat: compute reservations feat: add compute_reservations_delete/get/list Sep 6, 2024
@subfuzion subfuzion self-requested a review September 11, 2024 20:48
throw new Error('Reservation was not deleted.');
} catch (error) {
// Assert that the error message indicates the reservation wasn't found
expect(error.message).to.include(
Copy link
Contributor

@subfuzion subfuzion Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR; the only real nit I have is using chai just to make an expect call. This can easily be handled without an extra package dependency (I realize the package dependency was already there for other tests, but String.prototype.includes() would do what you need here). Ideally, we'd have fewer test dependencies and rely more on core APIs, a goal I think we'll articulate more. That being said, maybe keep it in mind for future refactoring and let's get your queue merged! :)

@subfuzion subfuzion merged commit 38af8df into main Sep 11, 2024
@subfuzion subfuzion deleted the compute_reservations branch September 11, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants