-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: add compute_reservations_delete/get/list #3834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| 'use strict'; | ||
| async function main() { | ||
| // [START compute_reservation_delete] | ||
| // Import the Compute library | ||
| const computeLib = require('@google-cloud/compute'); | ||
| // Instantiate a reservationsClient | ||
| const reservationsClient = new computeLib.ReservationsClient(); | ||
| // Instantiate a zoneOperationsClient | ||
| const zoneOperationsClient = new computeLib.ZoneOperationsClient(); | ||
| /** | ||
| * TODO(developer): Update these variables before running the sample. | ||
| */ | ||
| // The ID of the project where your reservation is located. | ||
| const projectId = await reservationsClient.getProjectId(); | ||
| // The zone where your reservation is located. | ||
| const zone = 'us-central1-a'; | ||
| // The name of the reservation to delete. | ||
| const reservationName = 'reservation-01'; | ||
|
|
||
| async function callDeleteReservation() { | ||
| // Delete the reservation | ||
| const [response] = await reservationsClient.delete({ | ||
| project: projectId, | ||
| reservation: reservationName, | ||
| zone, | ||
| }); | ||
|
|
||
| let operation = response.latestResponse; | ||
|
|
||
| // Wait for the delete reservation operation to complete. | ||
| while (operation.status !== 'DONE') { | ||
| [operation] = await zoneOperationsClient.wait({ | ||
| operation: operation.name, | ||
| project: projectId, | ||
| zone: operation.zone.split('/').pop(), | ||
| }); | ||
| } | ||
| } | ||
| await callDeleteReservation(); | ||
| // [END compute_reservation_delete] | ||
| } | ||
| main().catch(err => { | ||
| console.error(err); | ||
| process.exitCode = 1; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| async function main() { | ||
| // [START compute_reservation_get] | ||
| // Import the Compute library | ||
| const computeLib = require('@google-cloud/compute'); | ||
|
|
||
| // Instantiate a reservationsClient | ||
| const reservationsClient = new computeLib.ReservationsClient(); | ||
|
|
||
| /** | ||
| * TODO(developer): Update these variables before running the sample. | ||
| */ | ||
| // The ID of the project where your reservation is located. | ||
| const projectId = await reservationsClient.getProjectId(); | ||
| // The zone where your reservation is located. | ||
| const zone = 'us-central1-a'; | ||
| // The name of the reservation to return. | ||
| const reservationName = 'reservation-01'; | ||
|
|
||
| async function callGetReservation() { | ||
| const requestedReservation = ( | ||
| await reservationsClient.get({ | ||
| project: projectId, | ||
| zone, | ||
| reservation: reservationName, | ||
| }) | ||
| )[0]; | ||
|
|
||
| console.log(JSON.stringify(requestedReservation)); | ||
| } | ||
|
|
||
| await callGetReservation(); | ||
| // [END compute_reservation_get] | ||
| } | ||
|
|
||
| main().catch(err => { | ||
| console.error(err); | ||
| process.exitCode = 1; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright 2024 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| async function main() { | ||
| // [START compute_reservation_list] | ||
| // Import the Compute library | ||
| const computeLib = require('@google-cloud/compute'); | ||
|
|
||
| // Instantiate a reservationsClient | ||
| const reservationsClient = new computeLib.ReservationsClient(); | ||
|
|
||
| /** | ||
| * TODO(developer): Update these variables before running the sample. | ||
| */ | ||
| // The ID of the project where your reservations are located. | ||
| const projectId = await reservationsClient.getProjectId(); | ||
| // The zone where your reservations are located. | ||
| const zone = 'us-central1-a'; | ||
|
|
||
| async function callGetReservations() { | ||
| const reservations = ( | ||
| await reservationsClient.list({ | ||
| project: projectId, | ||
| zone, | ||
| }) | ||
| )[0]; | ||
|
|
||
| console.log(JSON.stringify(reservations)); | ||
| } | ||
|
|
||
| await callGetReservations(); | ||
| // [END compute_reservation_list] | ||
| } | ||
|
|
||
| main().catch(err => { | ||
| console.error(err); | ||
| process.exitCode = 1; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR; the only real nit I have is using
chaijust to make anexpectcall. This can easily be handled without an extra package dependency (I realize the package dependency was already there for other tests, butString.prototype.includes()would do what you need here). Ideally, we'd have fewer test dependencies and rely more on core APIs, a goal I think we'll articulate more. That being said, maybe keep it in mind for future refactoring and let's get your queue merged! :)