Skip to content

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 30, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj self-assigned this Aug 30, 2024
@gryczj gryczj requested review from a team as code owners August 30, 2024 16:46
@snippet-bot
Copy link

snippet-bot bot commented Aug 30, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Aug 30, 2024
@gryczj gryczj changed the title Compute reservation get feat: compute reservation get Aug 30, 2024
@gryczj
Copy link
Contributor Author

gryczj commented Aug 30, 2024

Please review #3808, #3807, #3814 first

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2024
@gryczj gryczj force-pushed the compute_reservation_get branch from ac99919 to a25733a Compare August 30, 2024 16:49
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2024
@gryczj gryczj force-pushed the compute_reservation_get branch from a25733a to f064a3d Compare August 30, 2024 17:09
@subfuzion
Copy link
Contributor

Pending #3807

@subfuzion subfuzion self-requested a review September 3, 2024 18:50
@gryczj gryczj force-pushed the compute_reservation_get branch from f064a3d to b7c5535 Compare September 5, 2024 09:04
@gryczj
Copy link
Contributor Author

gryczj commented Sep 5, 2024

Too many pipeline runs exceed the limit for create storage pool in the project. compute/test/createComputeHyperdiskFromPool.test.js- For now those tests are skipped, all PRs related to reservation need to be review and merged one by one.

@gryczj
Copy link
Contributor Author

gryczj commented Sep 6, 2024

Sample has been moved to #3834 to avoid conflicts and dependency issues

@gryczj gryczj closed this Sep 6, 2024
@gryczj gryczj deleted the compute_reservation_get branch September 6, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants