Skip to content

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 30, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj self-assigned this Aug 30, 2024
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Aug 30, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2024
@gryczj gryczj force-pushed the compute_reservation_delete branch from 3733f9f to 14ef48a Compare August 30, 2024 14:27
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 30, 2024
@gryczj gryczj changed the title Compute reservation delete feat: compute reservation delete Aug 30, 2024
@gryczj gryczj marked this pull request as ready for review August 30, 2024 14:44
@gryczj gryczj requested review from a team as code owners August 30, 2024 14:44
@snippet-bot
Copy link

snippet-bot bot commented Aug 30, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj
Copy link
Contributor Author

gryczj commented Aug 30, 2024

Please review #3808 and #3807 first

@subfuzion
Copy link
Contributor

Pending #3807

@subfuzion subfuzion self-requested a review September 3, 2024 18:50
@gryczj gryczj force-pushed the compute_reservation_delete branch from 321aaec to 041b29b Compare September 5, 2024 05:38
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@gryczj gryczj force-pushed the compute_reservation_delete branch from 041b29b to bfdfe28 Compare September 5, 2024 06:13
@gryczj
Copy link
Contributor Author

gryczj commented Sep 5, 2024

Too many pipeline runs exceed the limit for create storage pool in the project. All PRs related to reservation need to be review and merged one by one.

@gryczj gryczj closed this Sep 6, 2024
@gryczj
Copy link
Contributor Author

gryczj commented Sep 6, 2024

Sample has been moved to #3834 to avoid conflicts and dependency issues

@gryczj gryczj deleted the compute_reservation_delete branch September 6, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants