feat: compute reservation create

[gryczj]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[subfuzion]

Hi @gryczj. Last week I helped with a few changes to try to stabilize ensuring resources didn't exist from previous failed tests and were removed after tests. I think you need to work with your team to come up with a more optimal solution for handling this cleanly and reliably. It seems that this is a problematic area (I had to insert delays with retries, but it felt like a bit of a brute force hack). Perhaps for compute instances, you really do need to separate these concerns into a more robust set up and tear down module with retries that you import that ensures this happens in a consistently reliable way before erroring. If it's this hard for us to do, then it's going to be hard for our customers as well, so let's convert this to draft mode while you take a bit of time to coordinate with your team to come up with something that showcases the proper way to handle this. Thank you!

[gryczj]

Hi @gryczj. Last week I helped with a few changes to try to stabilize ensuring resources didn't exist from previous failed tests and were removed after tests. I think you need to work with your team to come up with a more optimal solution for handling this cleanly and reliably. It seems that this is a problematic area (I had to insert delays with retries, but it felt like a bit of a brute force hack). Perhaps for compute instances, you really do need to separate these concerns into a more robust set up and tear down module with retries that you import that ensures this happens in a consistently reliable way before erroring. If it's this hard for us to do, then it's going to be hard for our customers as well, so let's convert this to draft mode while you take a bit of time to coordinate with your team to come up with something that showcases the proper way to handle this. Thank you!

@subfuzion Please see: #3808

[snippet-bot]

Here is the summary of changes.

You are about to add 1 region tag.

• compute/reservations/createReservationFromProperties.js:20, tag compute_reservation_create

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[subfuzion]

@gryczj I merged #3808 and then updated this branch, but that doesn't seem to have resolved the issue, unfortunately:

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/actions/runs/10686130157/job/29620561886?pr=3807#step:9:268

[gryczj]

We can't create storage pool in europe zone. Changed to US as it was before. The same problem was in Java directory: GoogleCloudPlatform/java-docs-samples@e243370