Key upload #8714

bohengy · 2023-08-19T10:51:42Z

Add a new field jwks-json to resource WorkforcePoolProvider.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

PRODUCT: added `jwksJson` field to `WorkforcePoolProvider` resource (beta)

modular-magician · 2023-08-19T10:52:29Z

Hello! I am a robot. It looks like you are a: Community Contributor ~~Googler~~ ~~Core Contributor~~. Tests will require approval to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

…into key-upload

modular-magician · 2023-08-22T17:12:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 26 insertions(+))
Terraform Beta: Diff ( 3 files changed, 174 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

mmv1/templates/terraform/examples/iam_workforce_pool_provider_oidc_upload_key.tf.erb

...d_party/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb

modular-magician · 2023-08-22T18:25:17Z

Tests analytics

Total tests: 2984
Passed tests 2688
Skipped tests: 295
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePoolProvider_oidc_beta

Get to know how VCR tests work

modular-magician · 2023-08-22T18:28:05Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePoolProvider_oidc_beta[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

melinath · 2023-08-24T22:07:20Z

/gcbrun

melinath

a couple changes & it looks like there are also merge conflicts to resolve. Could you also make sure the release note matches the guidance at https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/?

mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

...d_party/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

modular-magician · 2023-08-25T10:42:50Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 89 insertions(+))
Terraform Beta: Diff ( 3 files changed, 133 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2023-08-25T11:54:50Z

Tests analytics

Total tests: 2989
Passed tests 2692
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcUploadKeyExample

Get to know how VCR tests work

modular-magician · 2023-08-25T11:56:12Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcUploadKeyExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-25T19:27:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 26 insertions(+))
Terraform Beta: Diff ( 3 files changed, 133 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2023-08-25T20:37:57Z

Tests analytics

Total tests: 2989
Passed tests 2692
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcUploadKeyExample

Get to know how VCR tests work

modular-magician · 2023-08-25T20:40:03Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcUploadKeyExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

modular-magician · 2023-08-25T21:22:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 26 insertions(+))
Terraform Beta: Diff ( 3 files changed, 133 insertions(+))
TF Conversion: Diff ( 1 file changed, 11 insertions(+))

modular-magician · 2023-08-25T22:34:45Z

Tests analytics

Total tests: 2990
Passed tests 2693
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcUploadKeyExample

Get to know how VCR tests work

modular-magician · 2023-08-25T22:38:30Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcUploadKeyExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

melinath · 2023-08-25T22:43:12Z

Thanks, lgtm!

* add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (#8520) Co-authored-by: Shuya Ma <[email protected]> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (#8744) * Made breaking change detector own its own setup and build process (#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <[email protected]> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <[email protected]> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <[email protected]> * Go changelog (#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <[email protected]> * Fix acctest import specifying the beta version instead of GA (#8736) * Cleanup deprecated folders (#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (#8763) * Adds the synthetic monitor target type as an option for uptime checks. (#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (#8761) * Update example for google_compute_addresses data source (#8765) * Remove myself from vacation list (#8770) * Document database flags type change (#8769) * Added some missing what's next links (#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (#8751) Co-authored-by: Shuya Ma <[email protected]> * Add workflow for membership checker unit tests (#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> --------- Co-authored-by: Scott Suarez <[email protected]> * Key upload (#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (#8776) * make distribution_policy_target_shape updatable (#8774) Co-authored-by: Edward Sun <[email protected]> * feat(google_container_cluster): support fqdn network policy (#8461) Signed-off-by: Tsubasa Nagasawa <[email protected]> * Redis cluster terraform support (#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <[email protected]> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Baruch Steinberg <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: vaibhav-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Daniel Koss <[email protected]> Co-authored-by: Ryan White <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Sean McGivern <[email protected]> Co-authored-by: bohengy <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Yanwei Guo <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Himani Khanduja <[email protected]>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <[email protected]> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <[email protected]> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <[email protected]> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <[email protected]> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <[email protected]> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> --------- Co-authored-by: Scott Suarez <[email protected]> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <[email protected]> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <[email protected]> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <[email protected]> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Baruch Steinberg <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: vaibhav-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Daniel Koss <[email protected]> Co-authored-by: Ryan White <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Sean McGivern <[email protected]> Co-authored-by: bohengy <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Yanwei Guo <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Himani Khanduja <[email protected]>

* add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <[email protected]> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <[email protected]> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <[email protected]> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <[email protected]> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <[email protected]> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> --------- Co-authored-by: Scott Suarez <[email protected]> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <[email protected]> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <[email protected]> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <[email protected]> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Baruch Steinberg <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: vaibhav-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Daniel Koss <[email protected]> Co-authored-by: Ryan White <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Sean McGivern <[email protected]> Co-authored-by: bohengy <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Yanwei Guo <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Himani Khanduja <[email protected]>

* add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <[email protected]> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <[email protected]> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <[email protected]> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <[email protected]> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <[email protected]> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> --------- Co-authored-by: Scott Suarez <[email protected]> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <[email protected]> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <[email protected]> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <[email protected]> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Baruch Steinberg <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: vaibhav-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Daniel Koss <[email protected]> Co-authored-by: Ryan White <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Sean McGivern <[email protected]> Co-authored-by: bohengy <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Yanwei Guo <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Himani Khanduja <[email protected]>

bohengy and others added 2 commits August 19, 2023 09:46

add oidc key upload

913e7f1

Merge branch 'GoogleCloudPlatform:main' into key-upload

f76165d

modular-magician requested a review from melinath August 19, 2023 10:52

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 19, 2023

bohengy added 3 commits August 19, 2023 10:56

fix a bug

0ccd4fb

Merge branch 'key-upload' of https://github.com/bohengy/magic-modules …

104658c

…into key-upload

fix a typo

3f19896

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Aug 22, 2023

melinath requested changes Aug 22, 2023

View reviewed changes

mmv1/templates/terraform/examples/iam_workforce_pool_provider_oidc_upload_key.tf.erb Show resolved Hide resolved

...d_party/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb Outdated Show resolved Hide resolved

add example

7f4b5d4

modular-magician requested a review from melinath August 23, 2023 11:08

modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Aug 23, 2023

melinath requested changes Aug 24, 2023

View reviewed changes

mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Show resolved Hide resolved

...d_party/terraform/services/iamworkforcepool/resource_iam_workforce_pool_provider_test.go.erb Outdated Show resolved Hide resolved

Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

0893dfe

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

modular-magician requested a review from melinath August 25, 2023 10:13

bohengy and others added 3 commits August 25, 2023 03:18

Merge branch 'main' into key-upload

87bb14a

remove unnecessary test

7a897ae

add a new line

d481e66

fix a bug

be36487

melinath requested changes Aug 25, 2023

View reviewed changes

mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Show resolved Hide resolved

Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

6deb8f7

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

modular-magician requested a review from melinath August 25, 2023 21:13

melinath approved these changes Aug 25, 2023

View reviewed changes

melinath merged commit 6b82263 into GoogleCloudPlatform:main Aug 25, 2023
9 checks passed

This was referenced Aug 25, 2023

Key upload hashicorp/terraform-provider-google-beta#6153

Merged

Key upload hashicorp/terraform-provider-google#15637

Merged

Key upload GoogleCloudPlatform/terraform-google-conversion#1343

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Key upload #8714

Key upload #8714

bohengy commented Aug 19, 2023 •

edited

Loading

modular-magician commented Aug 19, 2023

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

melinath commented Aug 24, 2023

melinath left a comment

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

melinath commented Aug 25, 2023

Key upload #8714

Key upload #8714

Conversation

bohengy commented Aug 19, 2023 • edited Loading

modular-magician commented Aug 19, 2023

modular-magician commented Aug 22, 2023

Diff report

modular-magician commented Aug 22, 2023

Tests analytics

Action taken

modular-magician commented Aug 22, 2023

melinath commented Aug 24, 2023

melinath left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 25, 2023

Diff report

modular-magician commented Aug 25, 2023

Tests analytics

Action taken

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

Diff report

modular-magician commented Aug 25, 2023

Tests analytics

Action taken

modular-magician commented Aug 25, 2023

modular-magician commented Aug 25, 2023

Diff report

modular-magician commented Aug 25, 2023

Tests analytics

Action taken

modular-magician commented Aug 25, 2023

Rerun these tests in REPLAYING mode to catch issues

melinath commented Aug 25, 2023

bohengy commented Aug 19, 2023 •

edited

Loading