Add ignore read on reservedIpRange field Filestore Instance #8520

bsteinberg · 2023-08-02T16:53:09Z

When using connectMode=PRIVATE_SERVICE_ACCESS, the returned value won't match the sent value as the returned value is an IP range from the provided named range.

It should be safe to ignore read on this field as it is immutable after instance creation.

Fixes hashicorp/terraform-provider-google#12877
b/257089398

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

filestore: fixed a bug causing premadiff on `reserved_ip_range` field in `google_filestore_instance`

modular-magician · 2023-08-02T16:53:33Z

Hello! I am a robot. It looks like you are a community contributor. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2023-08-02T17:03:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-02T18:06:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-02T19:55:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-02T20:25:13Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-02T20:47:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-02T20:59:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-02T22:05:29Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 5 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-02T23:46:15Z

Tests analytics

Total tests: 2922
Passed tests 2619
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFilestoreInstance_reservedIpRange_update

Get to know how VCR tests work

modular-magician · 2023-08-02T23:51:59Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFilestoreInstance_reservedIpRange_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-03T11:58:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-03T13:42:33Z

Tests analytics

Total tests: 2922
Passed tests 2619
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFilestoreInstance_reservedIpRange_update

Get to know how VCR tests work

modular-magician · 2023-08-03T13:48:57Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFilestoreInstance_reservedIpRange_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

shuyama1

@bsteinberg Thanks for making the change.

Looks like the test TestAccFilestoreInstance_reservedIpRange_update failed. Are you able to get it passed locally? Please let me know if you need help debugging.

modular-magician · 2023-08-21T17:46:20Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))

modular-magician · 2023-08-21T18:58:07Z

Tests analytics

Total tests: 2983
Passed tests 2687
Skipped tests: 295
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFilestoreInstance_reservedIpRange_update

Get to know how VCR tests work

modular-magician · 2023-08-21T19:04:37Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFilestoreInstance_reservedIpRange_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

mmv1/third_party/terraform/services/filestore/resource_filestore_instance_test.go

mmv1/products/filestore/Instance.yaml

modular-magician · 2023-08-22T08:50:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 7 deletions(-))

modular-magician · 2023-08-22T10:00:57Z

Tests analytics

Total tests: 2983
Passed tests 2686
Skipped tests: 295
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFilestoreInstance_reservedIpRange_update|TestAccFolderIamPolicy_basic

Get to know how VCR tests work

Co-authored-by: Shuya Ma <[email protected]>

shuyama1

Build failed with the following error:

bundler: failed to load command: compiler.rb (compiler.rb)
/mm-terraform-ga-head/mmv1/compile/core.rb:146:in `read': No such file or directory @ rb_sysopen - /mm-terraform-ga-head/mmv1/templates/terraform/custom_flatten/filestore_instance_networks_reserved_ip_range.go.erb (Errno::ENOENT)

Looks like we don't have the file filestore_instance_networks_reserved_ip_range.go.erb uploaded, the content of the file should something similar to https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/custom_flatten/compute_backend_service_iap_oauth2_client_secret.go.erb. Plus, I think we can remove ignore_read: true as the custom_flatten should be able to handle it to write back what's in the config to TF state.

bsteinberg · 2023-08-22T20:49:05Z

Build failed with the following error:
bundler: failed to load command: compiler.rb (compiler.rb)
/mm-terraform-ga-head/mmv1/compile/core.rb:146:in `read': No such file or directory @ rb_sysopen - /mm-terraform-ga-head/mmv1/templates/terraform/custom_flatten/filestore_instance_networks_reserved_ip_range.go.erb (Errno::ENOENT)
Looks like we don't have the file filestore_instance_networks_reserved_ip_range.go.erb uploaded, the content of the file should something similar to https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/custom_flatten/compute_backend_service_iap_oauth2_client_secret.go.erb. Plus, I think we can remove ignore_read: true as the custom_flatten should be able to handle it to write back what's in the config to TF state.

Indeed, created the file and missed to add it on commit.

As for removing the ignore_read: true, I'm ok with removing it, but left that in purpose as I saw this was the practice in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/compute/BackendService.yaml#L756

…flatten to handle it.

shuyama1 · 2023-08-22T20:56:11Z

Build failed with the following error:
bundler: failed to load command: compiler.rb (compiler.rb)
/mm-terraform-ga-head/mmv1/compile/core.rb:146:in `read': No such file or directory @ rb_sysopen - /mm-terraform-ga-head/mmv1/templates/terraform/custom_flatten/filestore_instance_networks_reserved_ip_range.go.erb (Errno::ENOENT)
Looks like we don't have the file filestore_instance_networks_reserved_ip_range.go.erb uploaded, the content of the file should something similar to main/mmv1/templates/terraform/custom_flatten/compute_backend_service_iap_oauth2_client_secret.go.erb. Plus, I think we can remove ignore_read: true as the custom_flatten should be able to handle it to write back what's in the config to TF state.
Indeed, created the file and missed to add it on commit.

As for removing the ignore_read: true, I'm ok with removing it, but left that in purpose as I saw this was the practice in main/mmv1/products/compute/BackendService.yaml#L756

I think the custom_flatten should override it, but it wouldn't harm to keep it. Yeah, let's just keep it for now then. Thanks for looking closely into it.

modular-magician · 2023-08-22T21:06:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 7 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 7 insertions(+), 8 deletions(-))

modular-magician · 2023-08-22T22:17:26Z

Tests analytics

Total tests: 2984
Passed tests 2688
Skipped tests: 295
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFilestoreInstance_reservedIpRange_update

Get to know how VCR tests work

modular-magician · 2023-08-22T22:23:31Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccFilestoreInstance_reservedIpRange_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

shuyama1

Okay, cross off what I just said in #8520 (comment). We still need to remove ignore_read, otherwise it would not have the custom_flatten added to the parent level flattener (see generated downstream code). yeah, I remembered I tested it locally but got confused somehow earlier. Sorry for the misleading info in my previous comment.

mmv1/products/filestore/Instance.yaml

…atten added to the parent level flattener. Co-authored-by: Shuya Ma <[email protected]>

modular-magician · 2023-08-23T08:40:12Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-08-23T09:50:25Z

Tests analytics

Total tests: 2986
Passed tests 2691
Skipped tests: 295
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

bsteinberg · 2023-08-23T10:04:17Z

Thanks @shuyama1, tests look good now.

…oudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (#8520) Co-authored-by: Shuya Ma <[email protected]> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (#8744) * Made breaking change detector own its own setup and build process (#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <[email protected]> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <[email protected]> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <[email protected]> * Go changelog (#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <[email protected]> * Fix acctest import specifying the beta version instead of GA (#8736) * Cleanup deprecated folders (#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (#8763) * Adds the synthetic monitor target type as an option for uptime checks. (#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (#8761) * Update example for google_compute_addresses data source (#8765) * Remove myself from vacation list (#8770) * Document database flags type change (#8769) * Added some missing what's next links (#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (#8751) Co-authored-by: Shuya Ma <[email protected]> * Add workflow for membership checker unit tests (#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> --------- Co-authored-by: Scott Suarez <[email protected]> * Key upload (#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (#8776) * make distribution_policy_target_shape updatable (#8774) Co-authored-by: Edward Sun <[email protected]> * feat(google_container_cluster): support fqdn network policy (#8461) Signed-off-by: Tsubasa Nagasawa <[email protected]> * Redis cluster terraform support (#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <[email protected]> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Baruch Steinberg <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: vaibhav-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Daniel Koss <[email protected]> Co-authored-by: Ryan White <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Sean McGivern <[email protected]> Co-authored-by: bohengy <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Yanwei Guo <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Himani Khanduja <[email protected]>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <[email protected]> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <[email protected]> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <[email protected]> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <[email protected]> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <[email protected]> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> --------- Co-authored-by: Scott Suarez <[email protected]> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <[email protected]> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <[email protected]> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <[email protected]> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Baruch Steinberg <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: vaibhav-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Daniel Koss <[email protected]> Co-authored-by: Ryan White <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Sean McGivern <[email protected]> Co-authored-by: bohengy <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Yanwei Guo <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Himani Khanduja <[email protected]>

…oudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]>

* Add BigLake Table Resource * add: biglake table example * add: biglake table update test * update: hive_options * fix: wrong directory * trim: trailing whitespace * fix: incorrect example location * delete: incorrect file * add: acc tests for biglake table * Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723) * Add tests for `providerConfigure` testing `billing_project` config * Fix `billing_project` test * Add tests for `providerConfigure` testing `region` config * Add tests for `providerConfigure` testing `zone` config * Add tests for `providerConfigure` testing `user_project_override` config * Remove old redundant `TestHandleSDKDefaults_*` tests * Update code following creation of `transport` package * Reposition `transport_tpg` in imports * Add WIP of scopes test * Fix defect in test case * Fix scopes test * Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config * Make test error messages clearer w.r.t provider config from user versus derived Config struct * Fix import issue after rebase * Add comments separating types of test case, add cases for empty strings overwritten by ENVs * Rebase PR to pull in changes, including service package split * Add test cases that show empty strings are ignored and ENVs are used instead * Update text in test failure messages, add comments to signpost different types of test case * Make lack of error more explicit in test case * Fix import issues from rebasing branch * update use of `ioutil` to `os` * Make imports match what's on main * Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath` * Add missing comma * Move file into `provider_test` package, update imports and remove duplicate code * Fix defect when trying to access `CredentialsFromJSON` function * Add missing function calls to set ENVs used in tests * Update tests for region field, add test case for use of self links * Aad test case for zone field, self links are not shortened and usable * Remove test case; `ConflictsWith` on fields not testable at this level * Update test case names, add comments * TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685) * Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date. * Add ability to set project descriptions using a context parameter * Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter * Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful * Update tag for nightly test builds to be static/consistent * Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]> * b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744) * Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705) * Made breaking change detector own its own setup and build process * Moved breaking change detector unit tests to github action * Corrected breaking change detector unit test setup * Added back package name updates for tpgb new * made unit tests use a shallow clone * Limit breaking change detector unit tests to runs that modify the tool Co-authored-by: Scott Suarez <[email protected]> * Update .ci/scripts/go-plus/github-differ/generate_comment.sh Co-authored-by: Scott Suarez <[email protected]> * Minor Cleanup * Intentionally broke breaking change detector * Revert "Intentionally broke breaking change detector" This reverts commit bcb6ba8. * Intentionally caused panic in breaking change detector at runtime * Made a breaking change * Added additional logging * Removed export in generate_comment.sh export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script * Made failure get set to 1 instead of $? * Added bin/ cleanup * Revert "Intentionally caused panic in breaking change detector at runtime" This reverts commit a16c0cd. * Fixed package name replacement for google-beta * Re-added export of TPG/TPGB BREAKING * Added comment explaining the export location * Revert "Made a breaking change" This reverts commit 2deecd7. --------- Co-authored-by: Scott Suarez <[email protected]> * Go changelog (GoogleCloudPlatform#8727) * Add copy of go-changelog to tools * Add changelog checker to pre-build validation * Log errors instead of commenting * Move check changelog to separate workflow * Mark lines for removal * Remove unused go-changelog tools * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> * Make old changelog checker a no-op --------- Co-authored-by: Scott Suarez <[email protected]> * Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736) * Cleanup deprecated folders (GoogleCloudPlatform#8720) * Remove folder resources and data_sources * Remove utility files * Move more utility files * Fix tgc * Import provider package in tgc * Remove utils files * Remove test lines from changelog checker (GoogleCloudPlatform#8763) * Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709) * Adds synthetic_monitor type that lives alongside resource_group and monitored_resource * removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided * Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows. * Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762) * Removed guard around operation WithResponse method Resolved hashicorp/terraform-provider-google#15618 * Handle missing resource inside response more gracefully * Add zli82016 to the vacation list (GoogleCloudPlatform#8761) * Update example for google_compute_addresses data source (GoogleCloudPlatform#8765) * Remove myself from vacation list (GoogleCloudPlatform#8770) * Document database flags type change (GoogleCloudPlatform#8769) * Added some missing what's next links (GoogleCloudPlatform#8733) * Added some missing what's next links * reverted changes to run-tests.md * Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751) Co-authored-by: Shuya Ma <[email protected]> * Add workflow for membership checker unit tests (GoogleCloudPlatform#8760) * Add workflow for membership checker unit tests * Apply suggestions from code review Co-authored-by: Scott Suarez <[email protected]> --------- Co-authored-by: Scott Suarez <[email protected]> * Key upload (GoogleCloudPlatform#8714) * add oidc key upload * fix a bug * fix a typo * add example * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * remove unnecessary test * add a new line * fix a bug * Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml Co-authored-by: Stephen Lewis (Burrows) <[email protected]> --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771) * removed require * remove required for job * Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776) * make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774) Co-authored-by: Edward Sun <[email protected]> * feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461) Signed-off-by: Tsubasa Nagasawa <[email protected]> * Redis cluster terraform support (GoogleCloudPlatform#8567) * Redis cluster terraform support * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * updating cluster resource * update * update * update * update * update * update * update * update * update SCPolicy * Update Service connection policy * Update Service connection policy --------- Co-authored-by: Himani Khanduja <[email protected]> * move: Table.yaml to `biglake` * update: switch to parent id convention * update: example to use parent id convention * update: continue to update to parent convention * add: biglake table custom import * fix: correct usage of names * fix: extra comma * fix: parameter spec. * fix: parameters spec * delete: remove location param * fix: build * fix: correct url * add: spec custom import * update: switch to id_format over custom import * fix: remove location from resource test. * fix: test names * add: serde_info to acc test * fix: serde_info is a struct * remove: serde_info due to api bug. * delete: unsupported serdeinfo field * fix: use example person names * update: mark `database` immutable * update: change more fields in update test --------- Signed-off-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: Sarah French <[email protected]> Co-authored-by: Baruch Steinberg <[email protected]> Co-authored-by: Shuya Ma <[email protected]> Co-authored-by: vaibhav-google <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Scott Suarez <[email protected]> Co-authored-by: Thomas Rodgers <[email protected]> Co-authored-by: Ryan Oaks <[email protected]> Co-authored-by: Zhenhua Li <[email protected]> Co-authored-by: Daniel Koss <[email protected]> Co-authored-by: Ryan White <[email protected]> Co-authored-by: Riley Karson <[email protected]> Co-authored-by: Sean McGivern <[email protected]> Co-authored-by: bohengy <[email protected]> Co-authored-by: Stephen Lewis (Burrows) <[email protected]> Co-authored-by: Yanwei Guo <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Tsubasa Nagasawa <[email protected]> Co-authored-by: himanikh <[email protected]> Co-authored-by: Himani Khanduja <[email protected]>

modular-magician requested a review from shuyama1 August 2, 2023 16:53

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from c5f5e00 to c0cb511 Compare August 2, 2023 19:44

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from c0cb511 to 65bf314 Compare August 2, 2023 20:15

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from 65bf314 to a052faa Compare August 2, 2023 20:38

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from a052faa to 8941511 Compare August 2, 2023 20:48

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from 8941511 to 8bb3bcb Compare August 2, 2023 21:54

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from 8bb3bcb to c07060e Compare August 3, 2023 11:47

shuyama1 reviewed Aug 4, 2023

View reviewed changes

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from c07060e to 8edf6c2 Compare August 21, 2023 17:38

modular-magician requested a review from shuyama1 August 21, 2023 17:39

shuyama1 requested changes Aug 21, 2023

View reviewed changes

modular-magician requested a review from shuyama1 August 22, 2023 08:42

bsteinberg and others added 2 commits August 22, 2023 20:38

Add ignore read on reservedIpRange field.

875511d

Ignore reservedIpRange field verification in tests.

b614bc5

Co-authored-by: Shuya Ma <[email protected]>

shuyama1 reviewed Aug 22, 2023

View reviewed changes

As ignore_read currently does not work for nested fields, use custom_…

d6d2295

…flatten to handle it.

bsteinberg force-pushed the ignore-reserved-ip-range-read-filestore branch from 3ddfa17 to d6d2295 Compare August 22, 2023 20:57

modular-magician requested a review from shuyama1 August 22, 2023 20:58

shuyama1 requested changes Aug 22, 2023

View reviewed changes

mmv1/products/filestore/Instance.yaml Outdated Show resolved Hide resolved

Need to remove ignore_read, otherwise it would not have the custom_fl…

ae42745

…atten added to the parent level flattener. Co-authored-by: Shuya Ma <[email protected]>

modular-magician requested a review from shuyama1 August 23, 2023 08:33

shuyama1 approved these changes Aug 24, 2023

View reviewed changes

shuyama1 merged commit 3fe2dcb into GoogleCloudPlatform:main Aug 24, 2023
9 checks passed

This was referenced Aug 24, 2023

Add ignore read on reservedIpRange field Filestore Instance hashicorp/terraform-provider-google-beta#6143

Merged

Add ignore read on reservedIpRange field Filestore Instance hashicorp/terraform-provider-google#15614

Merged

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 25, 2023

Add ignore read on reservedIpRange field Filestore Instance (GoogleCl…

7a5ccb4

…oudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]>

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023

Add ignore read on reservedIpRange field Filestore Instance (GoogleCl…

9604694

…oudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]>

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023

Add ignore read on reservedIpRange field Filestore Instance (GoogleCl…

6ca8f62

…oudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]>

joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023

Add ignore read on reservedIpRange field Filestore Instance (GoogleCl…

c339dd9

…oudPlatform#8520) Co-authored-by: Shuya Ma <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ignore read on reservedIpRange field Filestore Instance #8520

Add ignore read on reservedIpRange field Filestore Instance #8520

bsteinberg commented Aug 2, 2023 •

edited by shuyama1

Loading

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

modular-magician commented Aug 3, 2023

modular-magician commented Aug 3, 2023

modular-magician commented Aug 3, 2023

shuyama1 left a comment

modular-magician commented Aug 21, 2023

modular-magician commented Aug 21, 2023

modular-magician commented Aug 21, 2023

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

shuyama1 left a comment

bsteinberg commented Aug 22, 2023

shuyama1 commented Aug 22, 2023

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

modular-magician commented Aug 22, 2023

shuyama1 left a comment

modular-magician commented Aug 23, 2023

modular-magician commented Aug 23, 2023

bsteinberg commented Aug 23, 2023

Add ignore read on reservedIpRange field Filestore Instance #8520

Add ignore read on reservedIpRange field Filestore Instance #8520

Conversation

bsteinberg commented Aug 2, 2023 • edited by shuyama1 Loading

modular-magician commented Aug 2, 2023

modular-magician commented Aug 2, 2023

Diff report

modular-magician commented Aug 2, 2023

Diff report

modular-magician commented Aug 2, 2023

Diff report

modular-magician commented Aug 2, 2023

Diff report

modular-magician commented Aug 2, 2023

Diff report

modular-magician commented Aug 2, 2023

Diff report

modular-magician commented Aug 2, 2023

Diff report

modular-magician commented Aug 2, 2023

Tests analytics

Action taken

modular-magician commented Aug 2, 2023

modular-magician commented Aug 3, 2023

Diff report

modular-magician commented Aug 3, 2023

Tests analytics

Action taken

modular-magician commented Aug 3, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 21, 2023

Diff report

modular-magician commented Aug 21, 2023

Tests analytics

Action taken

modular-magician commented Aug 21, 2023

modular-magician commented Aug 22, 2023

Diff report

modular-magician commented Aug 22, 2023

Tests analytics

Action taken

shuyama1 left a comment

Choose a reason for hiding this comment

bsteinberg commented Aug 22, 2023

shuyama1 commented Aug 22, 2023

modular-magician commented Aug 22, 2023

Diff report

modular-magician commented Aug 22, 2023

Tests analytics

Action taken

modular-magician commented Aug 22, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented Aug 23, 2023

Diff report

modular-magician commented Aug 23, 2023

Tests analytics

bsteinberg commented Aug 23, 2023

bsteinberg commented Aug 2, 2023 •

edited by shuyama1

Loading