Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions #8685

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Aug 17, 2023

This PR is to address two areas where users of the new project might be confused:

  • Understanding what the new projects are used for
  • Understanding which builds are relevant to a release cut, when the timing of builds isn't strongly related to being a nightly test anymore.

To address these problems I'm going to add descriptions to projects in TeamCity, and also add a step to build configurations so they automatically tag themselves based on how they're triggered.

Builds triggered by the cron schedule at night will be labelled nightly-YYYY-MM-DD nightly-test, with the date in the tag. All other builds are tagged with one-off-build. Builds know if they're triggered by cron or not based on whether there's details about a user who triggered a given build (directly or indirectly, via dependencies)

Here's a test project where I set this up - if you trigger a build it'll be tagged appropriately. Note: this project has none of the ENVs set up, so all the builds will fail their tests but they'll be able to do the tagging fine.

Screenshot 2023-08-24 at 11 50 51

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 35 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 35 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 34 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 34 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 34 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 7 files changed, 34 insertions(+), 7 deletions(-))

@SarahFrench
Copy link
Collaborator Author

I've updated this PR to tag nightly tests with a static tag, instead of one that includes the date. This is because it'll be easier for users to use the 'filter by tags' feature to view only nightly test builds, and then look at the date information themselves. The old solution of each tag saying what night the build corresponds to helps users scan down the list of builds with their eyes but makes the filtering feature less usable.

See the filter by tags feature here, and how the old tags with dates in them could cause a problem over a long time:

Screenshot 2023-08-24 at 11 50 51

@SarahFrench SarahFrench merged commit 72d9661 into main Aug 24, 2023
9 checks passed
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 25, 2023
…builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
…builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
…builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent
melinath added a commit that referenced this pull request Sep 6, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (#8520)

Co-authored-by: Shuya Ma <[email protected]>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (#8744)

* Made breaking change detector own its own setup and build process (#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <[email protected]>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <[email protected]>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <[email protected]>

* Go changelog (#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <[email protected]>

* Fix acctest import specifying the beta version instead of GA (#8736)

* Cleanup deprecated folders (#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (#8761)

* Update example for google_compute_addresses data source (#8765)

* Remove myself from vacation list (#8770)

* Document database flags type change (#8769)

* Added some missing what's next links (#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (#8751)

Co-authored-by: Shuya Ma <[email protected]>

* Add workflow for membership checker unit tests (#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

---------

Co-authored-by: Scott Suarez <[email protected]>

* Key upload (#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (#8776)

* make distribution_policy_target_shape updatable (#8774)

Co-authored-by: Edward Sun <[email protected]>

* feat(google_container_cluster): support fqdn network policy (#8461)

Signed-off-by: Tsubasa Nagasawa <[email protected]>

* Redis cluster terraform support (#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <[email protected]>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: Sarah French <[email protected]>
Co-authored-by: Baruch Steinberg <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: vaibhav-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Daniel Koss <[email protected]>
Co-authored-by: Ryan White <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Sean McGivern <[email protected]>
Co-authored-by: bohengy <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Yanwei Guo <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Himani Khanduja <[email protected]>
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <[email protected]>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <[email protected]>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <[email protected]>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <[email protected]>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <[email protected]>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <[email protected]>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

---------

Co-authored-by: Scott Suarez <[email protected]>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <[email protected]>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <[email protected]>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <[email protected]>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: Sarah French <[email protected]>
Co-authored-by: Baruch Steinberg <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: vaibhav-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Daniel Koss <[email protected]>
Co-authored-by: Ryan White <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Sean McGivern <[email protected]>
Co-authored-by: bohengy <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Yanwei Guo <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Himani Khanduja <[email protected]>
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Sep 7, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <[email protected]>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <[email protected]>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <[email protected]>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <[email protected]>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <[email protected]>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <[email protected]>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

---------

Co-authored-by: Scott Suarez <[email protected]>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <[email protected]>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <[email protected]>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <[email protected]>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: Sarah French <[email protected]>
Co-authored-by: Baruch Steinberg <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: vaibhav-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Daniel Koss <[email protected]>
Co-authored-by: Ryan White <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Sean McGivern <[email protected]>
Co-authored-by: bohengy <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Yanwei Guo <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Himani Khanduja <[email protected]>
@SarahFrench SarahFrench deleted the teamcity-tag-builds-triggered-by-cron branch September 11, 2023 11:45
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <[email protected]>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <[email protected]>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <[email protected]>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <[email protected]>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <[email protected]>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <[email protected]>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

---------

Co-authored-by: Scott Suarez <[email protected]>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <[email protected]>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <[email protected]>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <[email protected]>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: Sarah French <[email protected]>
Co-authored-by: Baruch Steinberg <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: vaibhav-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Daniel Koss <[email protected]>
Co-authored-by: Ryan White <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Sean McGivern <[email protected]>
Co-authored-by: bohengy <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Yanwei Guo <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Himani Khanduja <[email protected]>
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* Add BigLake Table Resource

* add: biglake table example

* add: biglake table update test

* update: hive_options

* fix: wrong directory

* trim: trailing whitespace

* fix: incorrect example location

* delete: incorrect file

* add: acc tests for biglake table

* Add SDK provider configuration tests, part 2 (GoogleCloudPlatform#7723)

* Add tests for `providerConfigure` testing `billing_project` config

* Fix `billing_project` test

* Add tests for `providerConfigure` testing `region` config

* Add tests for `providerConfigure` testing `zone` config

* Add tests for `providerConfigure` testing `user_project_override` config

* Remove old redundant `TestHandleSDKDefaults_*` tests

* Update code following creation of `transport` package

* Reposition `transport_tpg` in imports

* Add WIP of scopes test

* Fix defect in test case

* Fix scopes test

* Implement test cases for user config including zero values, and update tests to asset when field should be unset but is found in config

* Make test error messages clearer w.r.t provider config from user versus derived Config struct

* Fix import issue after rebase

* Add comments separating types of test case, add cases for empty strings overwritten by ENVs

* Rebase PR to pull in changes, including service package split

* Add test cases that show empty strings are ignored and ENVs are used instead

* Update text in test failure messages, add comments to signpost different types of test case

* Make lack of error more explicit in test case

* Fix import issues from rebasing branch

* update use of `ioutil` to `os`

* Make imports match what's on main

* Update `testFakeCredentialsPath` to `transport_tpg.TestFakeCredentialsPath`

* Add missing comma

* Move file into `provider_test` package, update imports and remove duplicate code

* Fix defect when trying to access `CredentialsFromJSON` function

* Add missing function calls to set ENVs used in tests

* Update tests for region field, add test case for use of self links

* Aad test case for zone field, self links are not shortened and usable

* Remove test case; `ConflictsWith` on fields not testable at this level

* Update test case names, add comments

* TeamCity: Usability improvements : tag builds to distinguish nightly builds vs ad hoc builds, add project descriptions (GoogleCloudPlatform#8685)

* Add ability to tag TeamCity builds based on whether they're automated or ad-hoc. Nightly builds tagged with the date.

* Add ability to set project descriptions using a context parameter

* Refactor how date is formatted, to avoid problem where TeamCity interprets `%Y-%` as interpolating a `Y-` parameter

* Remove use of `TRIGGERED_BY`; value in build didn't match UI and isn't useful

* Update tag for nightly test builds to be static/consistent

* Add ignore read on reservedIpRange field Filestore Instance (GoogleCloudPlatform#8520)

Co-authored-by: Shuya Ma <[email protected]>

* b-283271112 Add "additionalScopes" under webSsoConfig for the "groups" (GoogleCloudPlatform#8744)

* Made breaking change detector own its own setup and build process (GoogleCloudPlatform#8705)

* Made breaking change detector own its own setup and build process

* Moved breaking change detector unit tests to github action

* Corrected breaking change detector unit test setup

* Added back package name updates for tpgb new

* made unit tests use a shallow clone

* Limit breaking change detector unit tests to runs that modify the tool

Co-authored-by: Scott Suarez <[email protected]>

* Update .ci/scripts/go-plus/github-differ/generate_comment.sh

Co-authored-by: Scott Suarez <[email protected]>

* Minor Cleanup

* Intentionally broke breaking change detector

* Revert "Intentionally broke breaking change detector"

This reverts commit bcb6ba8.

* Intentionally caused panic in breaking change detector at runtime

* Made a breaking change

* Added additional logging

* Removed export in generate_comment.sh

export hides the exit code of the command being run; assignment on its own does not. Export is not required in the context of a shell script

* Made failure get set to 1 instead of $?

* Added bin/ cleanup

* Revert "Intentionally caused panic in breaking change detector at runtime"

This reverts commit a16c0cd.

* Fixed package name replacement for google-beta

* Re-added export of TPG/TPGB BREAKING

* Added comment explaining the export location

* Revert "Made a breaking change"

This reverts commit 2deecd7.

---------

Co-authored-by: Scott Suarez <[email protected]>

* Go changelog (GoogleCloudPlatform#8727)

* Add copy of go-changelog to tools

* Add changelog checker to pre-build validation

* Log errors instead of commenting

* Move check changelog to separate workflow

* Mark lines for removal

* Remove unused go-changelog tools

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

* Make old changelog checker a no-op

---------

Co-authored-by: Scott Suarez <[email protected]>

* Fix acctest import specifying the beta version instead of GA (GoogleCloudPlatform#8736)

* Cleanup deprecated folders (GoogleCloudPlatform#8720)

* Remove folder resources and data_sources

* Remove utility files

* Move more utility files

* Fix tgc

* Import provider package in tgc

* Remove utils files

* Remove test lines from changelog checker (GoogleCloudPlatform#8763)

* Adds the synthetic monitor target type as an option for uptime checks. (GoogleCloudPlatform#8709)

* Adds synthetic_monitor type that lives alongside resource_group and monitored_resource
* removes requirement for either tcp_check or http_check to be provided, as neither is required when synthetic_monitor is provided
* Adds acceptance test, and example. A new test fixutre w/ zip file is provided for these flows.

* Removed guard around operation WithResponse method & improved error handling (GoogleCloudPlatform#8762)

* Removed guard around operation WithResponse method

Resolved hashicorp/terraform-provider-google#15618

* Handle missing resource inside response more gracefully

* Add zli82016 to the vacation list (GoogleCloudPlatform#8761)

* Update example for google_compute_addresses data source (GoogleCloudPlatform#8765)

* Remove myself from vacation list (GoogleCloudPlatform#8770)

* Document database flags type change (GoogleCloudPlatform#8769)

* Added some missing what's next links (GoogleCloudPlatform#8733)

* Added some missing what's next links

* reverted changes to run-tests.md

* Add: BigLake API Catalog Resource (GoogleCloudPlatform#8751)

Co-authored-by: Shuya Ma <[email protected]>

* Add workflow for membership checker unit tests (GoogleCloudPlatform#8760)

* Add workflow for membership checker unit tests

* Apply suggestions from code review

Co-authored-by: Scott Suarez <[email protected]>

---------

Co-authored-by: Scott Suarez <[email protected]>

* Key upload (GoogleCloudPlatform#8714)

* add oidc key upload

* fix a bug

* fix a typo

* add example

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* remove unnecessary test

* add a new line

* fix a bug

* Update mmv1/products/iamworkforcepool/WorkforcePoolProvider.yaml

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

---------

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

* Marks `template.volumes.secret.items.mode` field not required in Cloud Run V2 resources (GoogleCloudPlatform#8771)

* removed require

* remove required for job

* Removed MembershipRBACRoleBinding from ga provider (GoogleCloudPlatform#8776)

* make distribution_policy_target_shape updatable (GoogleCloudPlatform#8774)

Co-authored-by: Edward Sun <[email protected]>

* feat(google_container_cluster): support fqdn network policy (GoogleCloudPlatform#8461)

Signed-off-by: Tsubasa Nagasawa <[email protected]>

* Redis cluster terraform support (GoogleCloudPlatform#8567)

* Redis cluster terraform support

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* updating cluster resource

* update

* update

* update

* update

* update

* update

* update

* update

* update SCPolicy

* Update Service connection policy

* Update Service connection policy

---------

Co-authored-by: Himani Khanduja <[email protected]>

* move: Table.yaml to `biglake`

* update: switch to parent id convention

* update: example to use parent id convention

* update: continue to update to parent convention

* add: biglake table custom import

* fix: correct usage of names

* fix: extra comma

* fix: parameter spec.

* fix: parameters spec

* delete: remove location param

* fix: build

* fix: correct url

* add: spec custom import

* update: switch to id_format over custom import

* fix: remove location from resource test.

* fix: test names

* add: serde_info to acc test

* fix: serde_info is a struct

* remove: serde_info due to api bug.

* delete: unsupported serdeinfo field

* fix: use example person names

* update: mark `database` immutable

* update: change more fields in update test

---------

Signed-off-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: Sarah French <[email protected]>
Co-authored-by: Baruch Steinberg <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: vaibhav-google <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Scott Suarez <[email protected]>
Co-authored-by: Thomas Rodgers <[email protected]>
Co-authored-by: Ryan Oaks <[email protected]>
Co-authored-by: Zhenhua Li <[email protected]>
Co-authored-by: Daniel Koss <[email protected]>
Co-authored-by: Ryan White <[email protected]>
Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Sean McGivern <[email protected]>
Co-authored-by: bohengy <[email protected]>
Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Co-authored-by: Yanwei Guo <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Edward Sun <[email protected]>
Co-authored-by: Tsubasa Nagasawa <[email protected]>
Co-authored-by: himanikh <[email protected]>
Co-authored-by: Himani Khanduja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants