Redis cluster terraform support

[himanikh]

Supporting redis cluster - a new Cloud Memorystore Redis offering (beta)

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

`google_redis_cluster`

[modular-magician]

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

[modular-magician]

Hello! I am a robot. It looks like you are a community contributor. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 302 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1294 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 133 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 118 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  display_name = # value needed
  psc_configs {
    network = # value needed
  }
  region                  = # value needed
  replica_count           = # value needed
  transit_encryption_mode = # value needed
}

[modular-magician]

Tests analytics

Total tests: 2934
Passed tests 2629
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccRedisCluster_redisClusterNonhaExample|TestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_redisClusterNonhaExample[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

[modular-magician]

Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:

```release-note:TYPE
Release note
```

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 300 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1261 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 123 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_redis_cluster (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_redis_cluster" "primary" {
  psc_configs {
    network = # value needed
  }
}

[modular-magician]

Tests analytics

Total tests: 2938
Passed tests 2633
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_redisClusterHaExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_updateShardCount[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 300 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1261 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 123 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 299 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1260 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 123 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2939
Passed tests 2634
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_redisClusterHaExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_updateShardCount[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[slevenick]

Is this resource publicly available? I'm seeing failures on 404 no such method errors, which generally mean the URL is wrong or the API is not public yet.

[himanikh]

Is this resource publicly available? I'm seeing failures on 404 no such method errors, which generally mean the URL is wrong or the API is not public yet.

The visibility is restricted but the endpoint would be public available by 10/12. Meanwhile I can add the test accounts to allowlist to validate the changes. From the office hours I learnt that these are the accounts to allowlist:
ci-test-project-188019
ci-test-project-nightly-beta
ci-test-project-nightly-ga

[slevenick]

Cool, is the goal to get this to a state where we can merge it on 10/12?

[himanikh]

Correct!

[slevenick]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 299 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1260 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 123 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 119 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2942
Passed tests 2637
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateShardCount|TestAccRedisCluster_updateReplicaCount

Get to know how VCR tests work

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 380 insertions(+), 29 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1662 insertions(+), 31 deletions(-))
TF Conversion: Diff ( 1 file changed, 131 insertions(+))
TF OiCS: Diff ( 4 files changed, 142 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2991
Passed tests 2692
Skipped tests: 296
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount|TestAccRedisCluster_redisClusterHaExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRedisCluster_redisClusterHaExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 544 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1830 insertions(+), 29 deletions(-))
TF Conversion: Diff ( 1 file changed, 131 insertions(+))
TF OiCS: Diff ( 4 files changed, 142 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2991
Passed tests 2693
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRedisCluster_updateReplicaCount[Debug log]
TestAccRedisCluster_updateShardCount[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[slevenick]

Thanks for the contribution!

I talked with the team about the change to ServiceConnectionPolicies being considered a breaking change. Usually we try not to make changes like this even if they're technically correct, but since the current failure mode is so severe (panic on read) it makes sense to change this.