Updated strings support with recent CI testing and Z3 compatibility matrix. #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of Z3 (4.8.11, maybe earlier?) and CVC4 (1.8) have changed their string solver support to use unicode codepoints as their atomic alphabet, and changed the string escaping rules to be those specified by the SMTLib2.6 standard. Here, we change our string escaping rules to suit, and modify the SMTWriter module to express problems in term of unicode sequences instead of ASCII sequences. Fixes #56
Reenable the prevsiouly-broken stringTest3. Fixes #132.
Squash a warning.
Squash warnings.
kquick
changed the title
kquick
force-pushed
the
strings2_ci_2201
branch
from
8bd75c6 to
d3b1402
Compare
kquick
force-pushed
the
strings2_ci_2201
branch
from
21bf942 to
1c5d91c
Compare
robdockins
reviewed
Jan 11, 2022
robdockins
approved these changes
Jan 11, 2022
Closed
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 25, 2022
Pulls in: GaloisInc/what4#176 GaloisInc/what4#177 GaloisInc/what4#179 GaloisInc/what4#181 GaloisInc/crucible#945 GaloisInc/crucible#952 GaloisInc/crucible#948 GaloisInc/crucible#950 GaloisInc/crucible#947 GaloisInc/crucible#946 GaloisInc/crucible#944 GaloisInc/crucible#943 GaloisInc/crucible#939 GaloisInc/crucible#938 GaloisInc/crucible#931 GaloisInc/crucible#921 GaloisInc/crucible#933 GaloisInc/macaw#257 GaloisInc/macaw#249 GaloisInc/macaw#246 And a fix for: GaloisInc/macaw#260 Of these, GaloisInc/crucible#945 is the most disruptive, causing quite a few downstream changes in Macaw and a smaller number here in SAWScript, addressed in subsequent patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the string changes from PR 147, combined with latest master (including running with a full Z3 and GHC matrix) with expected failures for string tests on Z3 prior to 4.8.12.