uc-crux-llvm: Improve error handling in cases of a malformed LLVM module #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travitch
reviewed
Dec 9, 2021
Clarify when it is an LLVM problem vs. a UC-Crux problem, and unify error handling. Also, remove an unused constructor and don't export the constructors anymore.
Clarify when it's a UC-Crux bug vs. LLVM bug.
langston-barrett
force-pushed
the
lb/malformed-llvm-module
branch
2 times, most recently
from
b87b787 to
8e81d9a
Compare
langston-barrett
force-pushed
the
lb/malformed-llvm-module
branch
from
8e81d9a to
91bff84
Compare
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 25, 2022
Pulls in: GaloisInc/what4#176 GaloisInc/what4#177 GaloisInc/what4#179 GaloisInc/what4#181 GaloisInc/crucible#945 GaloisInc/crucible#952 GaloisInc/crucible#948 GaloisInc/crucible#950 GaloisInc/crucible#947 GaloisInc/crucible#946 GaloisInc/crucible#944 GaloisInc/crucible#943 GaloisInc/crucible#939 GaloisInc/crucible#938 GaloisInc/crucible#931 GaloisInc/crucible#921 GaloisInc/crucible#933 GaloisInc/macaw#257 GaloisInc/macaw#249 GaloisInc/macaw#246 And a fix for: GaloisInc/macaw#260 Of these, GaloisInc/crucible#945 is the most disruptive, causing quite a few downstream changes in Macaw and a smaller number here in SAWScript, addressed in subsequent patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, UC-Crux
paniced in a few places that could potentially indicate malformed LLVM modules. This change makes it more clear what might be Clang/rustc/whatever bugs.