String updates #147
Closed
String updates #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of Z3 (4.8.11, maybe earlier?) and CVC4 (1.8) have changed their string solver support to use unicode codepoints as their atomic alphabet, and changed the string escaping rules to be those specified by the SMTLib2.6 standard. Here, we change our string escaping rules to suit, and modify the SMTWriter module to express problems in term of unicode sequences instead of ASCII sequences. Fixes #56
Reenable the prevsiouly-broken stringTest3. Fixes #132.
Squash a warning.
Squash warnings.
|
Tests are failing here because the Z3 versions on the build machines (4.8.8 or 4.8.10) is too old. We need 4.8.11. |
|
@RyanGlScott, do you know enough Nix magic to know how to get newer Z3s for the build environments? I'm out of my depth. |
|
I'm afraid I'm out of my depth as well. Generally speaking, picking newer versions of packages than what a particular I wonder instead if it would be easier to use a dedicated GitHub Action that downloads a specific Z3 release, such as |
|
In that case I'll wait for @kquick to have time to look at this. |
|
Included in #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates regarding string theories for Z3 and CVC4.