crux-mir: remove default initialValue for crucible::any::Any #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
reviewed
Jan 6, 2022
robdockins
approved these changes
Jan 6, 2022
robdockins
added a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 25, 2022
Pulls in: GaloisInc/what4#176 GaloisInc/what4#177 GaloisInc/what4#179 GaloisInc/what4#181 GaloisInc/crucible#945 GaloisInc/crucible#952 GaloisInc/crucible#948 GaloisInc/crucible#950 GaloisInc/crucible#947 GaloisInc/crucible#946 GaloisInc/crucible#944 GaloisInc/crucible#943 GaloisInc/crucible#939 GaloisInc/crucible#938 GaloisInc/crucible#931 GaloisInc/crucible#921 GaloisInc/crucible#933 GaloisInc/macaw#257 GaloisInc/macaw#249 GaloisInc/macaw#246 And a fix for: GaloisInc/macaw#260 Of these, GaloisInc/crucible#945 is the most disruptive, causing quite a few downstream changes in Macaw and a smaller number here in SAWScript, addressed in subsequent patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, locals of type
Anywould be initialized to a (useless) default value. If the local was declared under a symbolic branch, then the value assigned under that branch would then get muxed with the default value, producing an error ("Attempted to mux ANY values of different runtime type") since the value assigned almost never had the same concrete/runtime type as the default. This was a major problem for #945, which halts simulation when that error occurs instead of turning it into an assertion failure.With this branch, we no longer set a default value for
Any-typed locals. (I forget the exact mechanism that allows this - probably something involvingMaybeType- but the same mechanism is already used for various other non-defaultable types, like function pointers.) Removing the default value eliminates the unnecessary mux and the associated error.