Conversation
I don't want to be installing dependencies each time I start the server
Not supported in this version, opted for inlining instead
Ensure that it's run if going through NPM scripts directly (e.g. Cloud.gov Pages)
| ```sh | ||
| docker-compose run web bash | ||
| ``` |
There was a problem hiding this comment.
oh wow I forgot we had docker instructions here, are these still valid? should we remove? (maybe separate PR)
There was a problem hiding this comment.
are these still valid? should we remove?
No idea, on either point 😅 The docker-compose.yml looks relatively straight-forward, so if it was working at some point, I assume (with low confidence) that it probably wouldn't be impacted by these changes.
assets/scss/main.css.scss
Outdated
| } | ||
|
|
||
| //override for touchpoints survey included via script | ||
| #fba-modal-dialog .usa-banner__header-text { |
There was a problem hiding this comment.
we just removed touchpoints, right?
There was a problem hiding this comment.
We did in #318, yes, with caveat that it "will likely return the survey after tax season". I'd be inclined to remove it as unused though. I can drop a comment on the old pull request about the removal to help with a potential future revert.
This changes the Sass compilation to use the
@18f/identity-build-sasspackage published through18f/identity-idp.Refer to GSA-TTS/identity-site#1000 and GSA-TTS/identity-site#1003 for rationale.
Additionally:
NODE_ENVhandling