LG-9325: Upgrade Login.gov Design System (v6.7.0)#319
Merged
Conversation
aduth
requested review from
anniehirshman-gsa,
gitmijn,
mitchellhenke and
nickttng
Contributor
|
@anniehirshman-gsa fysa - this update also affects the side navigation, both on desktop and mobile/tablet. the former is more obvious. |
Contributor
Author
|
@anniehirshman-gsa I pushed a handful of changes based on your feedback:
|
anniehirshman-gsa
approved these changes
Mar 31, 2023
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Looks fantastic, thanks for your help! 🎉
This was referenced Mar 31, 2023
Improve contrast
Avoid emojificiation of ↩
So automatic content typography styles (i.e. usa-link class) is applied consistently
Visited styling conflicts
aduth
force-pushed
the
aduth-upgrade-ldgs-6
branch
from
e2bf49d to
789a607
Compare
mmagsa
approved these changes
Apr 3, 2023
Jeremy1026
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the
identity-style-guidepackage from3.0.0to6.7.0.See CHANGELOG: https://github.com/18F/identity-style-guide/blob/main/CHANGELOG.md
The main impact here is the change in default font to Public Sans, plus the removal of "Close" buttons from Accordion components on the Support page. This also removes some custom button styles which appear to be unused (
.usa-button--big,.usa-button--secondary).View live: https://federalist-14ccf384-8bd5-4e30-aa95-a5fe5894e3c1.sites.pages.cloud.gov/preview/18f/identity-dev-docs/aduth-upgrade-ldgs-6/