-
Notifications
You must be signed in to change notification settings - Fork 609
Compile Sass with JavaScript package #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
9e442f8
cc86812
1b56daf
055c025
5903c95
7f7a186
8a5c6bc
b67bd9d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,32 @@ | ||
| run: install-dependencies | ||
| run: | ||
| make -j2 serve watch-css | ||
|
|
||
| serve: | ||
| bundle exec jekyll serve --host 0.0.0.0 --incremental | ||
|
|
||
| watch-css: | ||
| npm run watch:css | ||
|
|
||
| clean: | ||
| rm -rf _site | ||
|
|
||
| test: build | ||
| bundle exec rspec spec | ||
|
|
||
| build: install-dependencies | ||
| build-site: | ||
| bundle exec jekyll build | ||
|
|
||
| build-css: | ||
| npm run build:css | ||
|
|
||
| build: build-site build-css | ||
|
|
||
| install-dependencies: bundle npm | ||
|
|
||
| npm: | ||
| npm ci | ||
|
|
||
| bundle: | ||
| bundle check || bundle install | ||
|
|
||
| setup: install-dependencies |
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| .usa-prose { | ||
| figure { | ||
| max-width: 64ex; | ||
| margin-left: 0; | ||
| margin-right: 0; | ||
| text-align: center; | ||
|
|
||
| img { | ||
| width: 100%; | ||
| margin-bottom: 0.5em; | ||
| } | ||
|
|
||
| figcaption { | ||
| font-size: 0.8em; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #nav-links { | ||
| width: fit-content !important; | ||
| } | ||
|
|
||
| //override for touchpoints survey included via script | ||
| #fba-modal-dialog .usa-banner__header-text { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we just removed touchpoints, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We did in #318, yes, with caveat that it "will likely return the survey after tax season". I'd be inclined to remove it as unused though. I can drop a comment on the old pull request about the removal to help with a potential future revert.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed in b67bd9d. |
||
| color: white; | ||
|
|
||
| a { | ||
| color: white; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow I forgot we had docker instructions here, are these still valid? should we remove? (maybe separate PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, on either point 😅 The
docker-compose.ymllooks relatively straight-forward, so if it was working at some point, I assume (with low confidence) that it probably wouldn't be impacted by these changes.