-
Notifications
You must be signed in to change notification settings - Fork 482
Compile Sass with JavaScript package #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9e442f8
Split setup to separate make target
aduth cc86812
Update Jekyll to drop sassc
aduth 1b56daf
Compile Sass with JavaScript package
aduth 055c025
Remove load-path
aduth 5903c95
Prepare output directory in watch task
aduth 7f7a186
Ensure CSS built for Cloud.gov Pages
aduth 8a5c6bc
Initialize output CSS directory in NPM prescript
aduth b67bd9d
Remove unused Touchpoints styles
aduth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,32 @@ | ||
| run: install-dependencies | ||
| run: | ||
| make -j2 serve watch-css | ||
|
|
||
| serve: | ||
| bundle exec jekyll serve --host 0.0.0.0 --incremental | ||
|
|
||
| watch-css: | ||
| npm run watch:css | ||
|
|
||
| clean: | ||
| rm -rf _site | ||
|
|
||
| test: build | ||
| bundle exec rspec spec | ||
|
|
||
| build: install-dependencies | ||
| build-site: | ||
| bundle exec jekyll build | ||
|
|
||
| build-css: | ||
| npm run build:css | ||
|
|
||
| build: build-site build-css | ||
|
|
||
| install-dependencies: bundle npm | ||
|
|
||
| npm: | ||
| npm ci | ||
|
|
||
| bundle: | ||
| bundle check || bundle install | ||
|
|
||
| setup: install-dependencies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,11 @@ | |
| } | ||
|
|
||
| figcaption { | ||
| font-size: .8em; | ||
| font-size: 0.8em; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #nav-links { | ||
| width: fit-content !important; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wow I forgot we had docker instructions here, are these still valid? should we remove? (maybe separate PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, on either point 😅 The
docker-compose.ymllooks relatively straight-forward, so if it was working at some point, I assume (with low confidence) that it probably wouldn't be impacted by these changes.