Skip to content

sync main#3269

Merged
ca333 merged 11 commits intomainfrom
dev
Oct 27, 2025
Merged

sync main#3269
ca333 merged 11 commits intomainfrom
dev

Conversation

@ca333
Copy link
Copy Markdown
Contributor

@ca333 ca333 commented Oct 27, 2025

Summary by CodeRabbit

  • New Features

    • Added QR code scanner for recipient address input on mobile platforms (iOS/Android) in NFT withdrawals.
  • Improvements

    • Enhanced keyboard navigation on search fields and password input.
    • Improved error monitoring and diagnostics on iOS.
  • Refactor

    • Removed unnecessary dependencies and performed code cleanup.

smk762 and others added 11 commits October 26, 2025 13:50
none is not supported on iOS and throws errors in debug mode

If a developer chooses an inappropriate [TextInputAction] when running in debug mode, an error will be thrown. If the same thing is done in release mode, then instead of sending the inappropriate value, Android will use "unspecified" on the platform side and iOS will use "default" on the platform side.
`DEX address` pill -> `swap address`
fix(text-input-action): use contextual input actions other than none
add qr code scan button to nft withdraw input
@ca333 ca333 merged commit f2a7f1a into main Oct 27, 2025
5 of 12 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 27, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates localization from "dexAddress" to "swapAddress" across translation and UI files, integrates iOS-specific file descriptor monitoring in error paths across multiple bloc and startup locations, adds QR code scanning for NFT withdrawal recipient addresses, improves keyboard actions for password and search fields, and removes the TradingStatusBloc dependency from the coin list UI.

Changes

Cohort / File(s) Summary
Localization & Key Renaming
assets/translations/en.json, lib/views/wallet/coin_details/coin_details_info/coin_addresses.dart, lib/views/wallet/wallet_page/common/expandable_coin_list_item.dart, lib/views/wallet/wallet_page/wallet_main/active_coins_list.dart
Updated translation key from "dexAddress" to "swapAddress" in translation file and all associated UI references. Removed TradingStatusBloc dependency from expandable_coin_list_item, simplifying swap badge visibility logic to check only isSwapAddress flag.
iOS FD Monitoring Integration
lib/main.dart, lib/bloc/coins_bloc/coins_repo.dart, lib/bloc/withdraw_form/withdraw_form_bloc.dart
Added iOS-specific file descriptor monitoring via FdMonitorService: startup initialization in main.dart with 60-second interval, and diagnostic logging in error paths of asset activation and withdrawal operations. Platform checks (Platform.isIOS) guard all new telemetry code.
UI/UX Improvements
lib/views/nfts/details_page/withdraw/nft_withdraw_form.dart, lib/views/settings/widgets/security_settings/password_update_page.dart, lib/views/wallet/coins_manager/coins_manager_controls.dart, lib/views/wallet/wallet_page/wallet_main/wallet_manager_search_field.dart
Added mobile QR code scanner support for NFT withdrawal recipient address on non-web platforms. Updated TextInputAction from none to next (password field) and search (search fields) to enable proper keyboard behaviors. Reordered import statements in password update page.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Localization renames: Repetitive, straightforward key-to-key replacements across multiple files with no logic changes
  • iOS FD monitoring: Consistent pattern of platform checks and telemetry logging calls in error paths—similar implementation across three files
  • TextInputAction updates: Minor configuration tweaks to keyboard behavior
  • Key areas to verify:
    • Platform check consistency and FdMonitorService integration points in coins_repo.dart and withdraw_form_bloc.dart
    • QR code scanning flow in nft_withdraw_form.dart to ensure event dispatch and state handling are correct
    • Verify all "dexAddress" references have been updated to "swapAddress" and no instances were missed

Possibly related PRs

Suggested labels

iOS, QA

Suggested reviewers

  • takenagain
  • smk762
  • CharlVS

Poem

🐰 A rabbit hops through code today,
Swaps old "dex" words out of the way,
On iOS paths, monitoring flows,
QR codes scan where the address goes,
Keyboards now know just where to go! ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 162d169 and 8c6587f.

⛔ Files ignored due to path filters (1)
  • lib/generated/codegen_loader.g.dart is excluded by !**/generated/**
📒 Files selected for processing (11)
  • assets/translations/en.json (1 hunks)
  • lib/bloc/coins_bloc/coins_repo.dart (3 hunks)
  • lib/bloc/withdraw_form/withdraw_form_bloc.dart (4 hunks)
  • lib/main.dart (3 hunks)
  • lib/views/nfts/details_page/withdraw/nft_withdraw_form.dart (3 hunks)
  • lib/views/settings/widgets/security_settings/password_update_page.dart (2 hunks)
  • lib/views/wallet/coin_details/coin_details_info/coin_addresses.dart (1 hunks)
  • lib/views/wallet/coins_manager/coins_manager_controls.dart (1 hunks)
  • lib/views/wallet/wallet_page/common/expandable_coin_list_item.dart (2 hunks)
  • lib/views/wallet/wallet_page/wallet_main/active_coins_list.dart (1 hunks)
  • lib/views/wallet/wallet_page/wallet_main/wallet_manager_search_field.dart (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 8c6587f):

https://walletrc--pull-3269-merge-s4ohb8od.web.app

(expires Mon, 03 Nov 2025 21:51:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants