Skip to content

DEX address pill -> swap address#3247

Merged
ca333 merged 4 commits intodevfrom
clear-pill-name
Oct 27, 2025
Merged

DEX address pill -> swap address#3247
ca333 merged 4 commits intodevfrom
clear-pill-name

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Oct 26, 2025

Closes #2919
A follow up after #2974 based on feedback seeking greater clarity. swapAddress is also more consistent with the rest of the codebase.

This PR is largely cosmetic, a single word swap, though a slight adjustment was also made to the pill visibility logic to keep it consistent. Previously, no pill was shown in portfolio coin expanded list if trading was disabled, though it would appear in coin detail page.

Now it is shown regardless of trading status. This reduces a tiny amount of state checking.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch clear-pill-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 changed the title Clear pill name DEX address pill -> swap address Oct 26, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 26, 2025

Visit the preview URL for this PR (updated for commit d671c5d):

https://walletrc--pull-3247-merge-k6xsw6yq.web.app

(expires Sun, 02 Nov 2025 13:47:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@ca333 ca333 merged commit 0c414c2 into dev Oct 27, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants