fix(text-input-action): use contextual input actions other than none#3258
fix(text-input-action): use contextual input actions other than none#3258
Conversation
none is not supported on iOS and throws errors in debug mode If a developer chooses an inappropriate [TextInputAction] when running in debug mode, an error will be thrown. If the same thing is done in release mode, then instead of sending the inappropriate value, Android will use "unspecified" on the platform side and iOS will use "default" on the platform side.
WalkthroughThree UI components have their keyboard input actions updated: password form now uses "next" to advance between fields, while two search components use "search" instead of "none". One file's import order is reorganized. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5-10 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical iOS compatibility issue where TextInputAction.none was preventing keyboards from appearing in debug mode. The changes replace TextInputAction.none with contextually appropriate actions (search for search fields, next for password fields) across three affected UI components.
Key Changes:
- Replaced
TextInputAction.nonewithTextInputAction.searchin search input fields - Replaced
TextInputAction.nonewithTextInputAction.nextin password input fields - Reordered imports in password_update_page.dart to follow alphabetical convention
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wallet_manager_search_field.dart | Changed text input action from none to search for wallet search bar |
| coins_manager_controls.dart | Changed text input action from none to search for add asset search bar |
| password_update_page.dart | Changed text input action from none to next for password fields and reordered imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 7fe529b): https://walletrc--pull-3258-merge-gqwa07f9.web.app (expires Sun, 02 Nov 2025 20:55:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
smk762
left a comment
There was a problem hiding this comment.
Wallet overview search bar:
- tapping the search bar should open a keyboard, and
- tapping Enter/Done on the keyboard should dismiss it. Note: scrolling or tapping outside the keyboard does not dismiss it.
Add asset view search bar:
- tapping the "+" (Add Assets) button should open the Add Assets page, which should automatically open the keyboard.
- tapping Enter/Done on the keyboard should dismiss it
Password change page:
- upon opening the password change page, the keyboard should appear
- tapping Enter/Done/Next should navigate to the next input field
Functions as expected.
Note: A currently unmerged PR #3225 includes Dismiss keyboard on scroll for the Fiat onramp and Swap pages (44ca2fa)
Though this is opposing behavior, the affected pages are mutually exclusive, so this should be fine, but worth retesting once merged.
TextInputAction.noneis not supported on iOS and throws errors in debug mode when attempting to use the affected inputs below, preventing the keyboard from appearing.According to the documentation,
UI components affected
Expected behaviour
Wallet overview search bar:
Add asset view search bar:
Password change page:
Summary by CodeRabbit