Skip to content

add qr code scan button to nft withdraw input#3243

Merged
ca333 merged 1 commit intodevfrom
qr-scan-for-nft-withdraw
Oct 27, 2025
Merged

add qr code scan button to nft withdraw input#3243
ca333 merged 1 commit intodevfrom
qr-scan-for-nft-withdraw

Conversation

@smk762
Copy link
Copy Markdown
Collaborator

@smk762 smk762 commented Oct 26, 2025

closes #3203

To test:

  • login to a wallet with an nft and gas to send it on mobile app
  • see qr code button on nft withdraw form
  • use qr code button on nft withdraw form
  • confirm successful withdrawal.

Note:

  • The QR code button in NFT withdraw address input is only applied to mobile native apps.
  • Currently, the regular withdraw form shows the QR code in all platforms.

I'm unsure of the prevalence or utility of having the QR code in non-mobile builds. On my desktop with no camera, it leads to an error page - though on laptop, it spawns the webcam.
image

Suggest we either remove it for non-mobile, or add some form of camera detection to return an error message like "No camera - unable to scan QR codes".

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch qr-scan-for-nft-withdraw

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 53a79c8):

https://walletrc--pull-3243-merge-sofg7eg0.web.app

(expires Sun, 02 Nov 2025 06:01:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@ca333 ca333 merged commit 8c6587f into dev Oct 27, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants